Closed
Bug 1055823
Opened 10 years ago
Closed 10 years ago
Region info is not being sent in the API requests
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P1)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: krupa.mozbugs, Unassigned)
References
()
Details
Attachments
(1 file)
621.38 KB,
image/png
|
Details |
steps to reproduce: 1. Compare https://marketplace-feed-dev.allizom.org/ (with region set to RoW) and https://marketplace-feed-dev.allizom.org/?region=restofworld More button is missing if you don't explicitly set region in the URL
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Comment 2•10 years ago
|
||
Looks like region info is not being sent in the Feed API requests
Summary: More button, where art thou? → Region info is not being sent in the API requests
Updated•10 years ago
|
Priority: -- → P1
Comment 3•10 years ago
|
||
I don't remember what the intended behavior is, but this is what happens for me, each test made in a new incognito window: https://marketplace-feed-dev.allizom.org - /api/v2/fireplace/consumer-info/?lang=en-US&limit=25, whose response includes region: 'us' - /api/v2/feed/get/?lang=en-US&limit=10®ion=us, which loads the US feed as expected. This is confirmed by the presence of the "This will only be in the US Feed" feed element on the top of the feed. https://marketplace-feed-dev.allizom.org/?region=restofworld - /api/v2/fireplace/consumer-info/?lang=en-US&limit=25®ion=restofworld, whose response includes region: 'restofworld' - /api/v2/feed/get/?lang=en-US&limit=10®ion=restofworld, which loads the roW feed as expected. This is confirmed by the presence of the "This will only be in the RoW Feed" feed element on the top of the feed. https://marketplace-feed-dev.allizom.org/?region=us - /api/v2/fireplace/consumer-info/?lang=en-US&limit=25®ion=us, whose response includes region: 'us' - /api/v2/feed/get/?lang=en-US&limit=10®ion=restofworld, which loads the roW feed as expected. This is confirmed by the presence of the "This will only be in the RoW Feed" feed element on the top of the feed. All of this is exactly as expected. The region param is being sent when it should be, and overriden when it should be. I don't see any bugs here.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
Comment 4•10 years ago
|
||
Might be another case of bug 1048896 ? if so, send ashes there.
Comment 5•10 years ago
|
||
In Krupa's case, she had no region parameter in the URL, it said "Rest of World" on the bottom right, she was in the US, and it returned the US region. Though according to Mat, it might be a bigger problem/duplicate.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•