Closed
Bug 1055844
Opened 12 years ago
Closed 11 years ago
guess-msvc.bat uses Windows 7.0A SDK when the Windows 8.1 SDK is installed
Categories
(Firefox Build System :: MozillaBuild, task)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: jaws, Unassigned)
Details
Using mozilla-build v1.1.0,
I had to comment out the check for %ERRORLEVEL% preceding,
> FOR /F "tokens=2*" %%A IN ('REG QUERY "%SDK80KEY%" /v KitsRoot81') DO SET SDKDIR=%%B
in order to get the Windows 8.1 SDK to be used.
Through some simple echo-debugging, I found that after:
> REG QUERY "%MSVC10EXPRESSKEY%" /v ProductDir >nul 2>nul
> if "%VC10EXPRESSDIR%"=="" (
> IF %ERRORLEVEL% EQU 0 (
> FOR /F "tokens=2*" %%A IN ('REG QUERY "%MSVC10EXPRESSKEY%" /v ProductDir') DO SET VC10EXPRESSDIR=%%B
> )
> )
%ERRORLEVEL% would be set to 1 and never get reset to 0. I tried commenting out that check and it would still get set to 1, but at the next REG QUERY.
Comment 1•12 years ago
|
||
The %ERRORLEVEL% behaviour seems to be normal. This seems to be a problem with your current MSVC10 Express instalation.
Comment 2•12 years ago
|
||
If you want, you can try to change that piece of code for the following:
if "%VC10EXPRESSDIR%"=="" (
REG QUERY "%MSVC10EXPRESSKEY%" /v ProductDir >nul 2>nul
IF NOT ERRORLEVEL 1 (
FOR /F "tokens=2*" %%A IN ('REG QUERY "%MSVC10EXPRESSKEY%" /v ProductDir') DO SET VC10EXPRESSDIR=%%B
)
)
As can be seen on https://bugzilla.mozilla.org/attachment.cgi?id=8454878&action=diff
But i doubt that it will fix your issue.
Comment 3•12 years ago
|
||
Also check my comments on bug: https://bugzilla.mozilla.org/show_bug.cgi?id=990983
Comment 4•12 years ago
|
||
Personally, after checking my comments on bug 990983, i think you should try my proposed changes on bug 691292. Apply changes to both files and give me some feedback, this issue could have been pro-actively solved by me on that proposal, since i noticed some inconsistencies.
Comment 5•11 years ago
|
||
Had a chance to sit down with Jared at the recent all-hands meetup and gave him updated batch files with attachment 8454878 [details] [diff] [review] applied. Unfortunately, he still hit the same problem as before.
Comment 6•11 years ago
|
||
That is good to know Ryan. Does that mean that at least functionaly my changes are as good as the previous files? Also: did you applied the Attachment #8454417 [details] [diff] as well?
Comment 7•11 years ago
|
||
Attachment 8454878 [details] [diff] seems to work fine, yes. No, we didn't include attachment 8454417 [details] [diff] [review] as well. I actually want to discuss that with you at some point as I think we may want to change strategy a bit for these files.
Comment 8•11 years ago
|
||
Gecko 37 and MozillaBuild 2.0 have dropped support for Windows SDK <8.1, so this bug is rendered moot now (it won't even look for the older versions anymore). You can give a test build a spin using the link below. Feedback welcome!
http://people.mozilla.org/~rvandermeulen/MozillaBuildSetup2.0.0pre3.exe
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INCOMPLETE
Updated•3 years ago
|
Product: mozilla.org → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•