1055873 - [Remove], [Remove all] by mouse are broken in sub-dialog

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Alice0775 White]

See http://forums.mozillazine.org/viewtopic.php?p=13724777#p13724777

Regression window(fx)
Good:
https://hg.mozilla.org/integration/fx-team/rev/5f57fb99ab5c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140709024742
Bad:
https://hg.mozilla.org/integration/fx-team/rev/77728b5c5d7d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140709025430
Pushlog:
https://bugzilla.mozilla.org/show_bug.cgi?id=1035540

Regressed by:
ab15179de7d9	Richard Marti — Bug 1035540 - Convert Security pane dialogs to be in-content. r=MattN


Mozilla should provide TEST(manually/automatic)!

Comment 1

[Alice0775 White]

Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=5f57fb99ab5c&tochange=77728b5c5d7d

Comment 2

[Richard Marti (:Paenglab)]

With actual Nightly and self built Firefox from tip I can remove the entries in in-content- and normal dialogs. Is there something else I have to do to see this issue?

The patch had also nothing changed in exceptions dialog, only the call to open it was changed.

Comment 3

[Alice0775 White]

(In reply to Richard Marti (:Paenglab) from comment #2)
> With actual Nightly and self built Firefox from tip I can remove the entries
> in in-content- and normal dialogs. Is there something else I have to do to
> see this issue?
> 

Nothing special.
I can reproduce the problem on normal nightly and latest tip ffdd1a398105 on windows7 x64 and ubuntu i686.

Steps To Reproduce
1. Start Browser with newly clean profile
2. Login this site
3. Select "Never Remember for This Site" in door hanger popup

4. Open Preferences (Alt > Edit > Preferences | Alt > Tools > Options)
5. Select "Security" pane
6. Click [Exceprions...] button of Passwords group
7. Select a entry item in the list view of "Exceprions-Saved Passwords" sub-dialog
8. Click  [Remove]
   --- The entry stays here
9. Click  [Remove all]
   --- The entry stays here

Comment 4

[Alice0775 White]

FYI,
Mouse click of these buttons is broken.
Keypres ENTER of these buttons is working as expected.

Comment 5

[Alice0775 White]

It seems fix the problem when the following CSS is applied to the xul button elements.

  -moz-user-select: none;

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Alice0775 White from comment #4)
> FYI,
> Mouse click of these buttons is broken.
> Keypres ENTER of these buttons is working as expected.

This helped a lot. It's again this rule which breaks: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css#17

Matthew, what would be the best here? Should I add only a -moz-user-select: none; rule for the buttons?

I'm also thinking about moving this rule back from global to preferences as it breaks also a lot in Add-ons manager (bug 989469).

Comment 7

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Based on the description, I'm marking 33 and 34 as affected and tracking both releases.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: Bug1055873.patch

Added button with -moz-user-select: none;. I think, the best is to move the -moz-user-select back to the in-content prefs. This was added to make text on the prefs selectable and isn't needed on other places like Add-on manager.

Comment 10

[Matthew N. [:MattN]]

Comment on attachment 8481981 [details] [diff] [review]
Bug1055873.patch

Sorry for the delay

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/ab33462e890a

Comment 12

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/ab33462e890a

Comment 13

[:Gavin Sharp [email: [e-mail]]]

in-content prefs are only on Nightly, so I don't see how this could be relevant to Firefox 33/34.

Comment 15

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Assigning to Camelia since she's in charge of In-Content Preferences, and is likely to have the time to take this.

Comment 16

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 35.0a1 (buildID: 20140921030208).