1055970 - [Flatfish][Camera] Change "phone" string in Camera app

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Nino Vranešič [:elnino]]

Attachment: Error screenshot

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140716183446

Steps to reproduce:

1) Open Settings and go to Storage section.
2) Turn USB storage to Enabled.
3) Connect Flatfish to computer.
4) Open Camera app


Actual results:

Error message displays:
"Camera can not be used while phone is plugged in
Unplug the phone to capture photos and videos"


Expected results:

String in error message should be changed from "phone" to "tablet" or more general "device".

Comment 1

[Nino Vranešič [:elnino]]

Info about build:

OS version: 2.1.0.0-prerelease
Platform version: 33.01a
Build Identifier: 20140626015928
Git commit info: 2014-6-25 15:36:44, bd588a2

Comment 2

[Gaurav Mittal (gauravmittal1995)]

Attachment: PR for the bug

Comment 3

[Théo Chevalier]

Comment on attachment 8494894 [details] [review]
PR for the bug

Hi Gauravmittal, thanks for the patch!

I have a few general comments, though:
Since you are changing existing strings, you need to update their entity names (See https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Changing_existing_strings for reference).
Also, Nino nor me are reviewers, you need to pick a peer/owner for the Camera App: David Flanagan, Diego Marcos, Wilson Page, Justin D'Arcangelo (You can find the full list for all apps on the Wiki: https://wiki.mozilla.org/Modules/FirefoxOS )

About the patch itself, sadly we can't just replace “phone” with “device“, see what's been done in bug 944604. Of course that would be a temp fix until bug 936532 is fixed.

Comment 4

[BMO Automation]

Firefox OS is not being worked on