Closed Bug 1055970 Opened 11 years ago Closed 7 years ago

[Flatfish][Camera] Change "phone" string in Camera app

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: elnino, Unassigned)

References

Details

(Whiteboard: [TCP][flatfish])

Attachments

(2 files)

Attached image Error screenshot
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release) Build ID: 20140716183446 Steps to reproduce: 1) Open Settings and go to Storage section. 2) Turn USB storage to Enabled. 3) Connect Flatfish to computer. 4) Open Camera app Actual results: Error message displays: "Camera can not be used while phone is plugged in Unplug the phone to capture photos and videos" Expected results: String in error message should be changed from "phone" to "tablet" or more general "device".
Whiteboard: [Flatfish]
Info about build: OS version: 2.1.0.0-prerelease Platform version: 33.01a Build Identifier: 20140626015928 Git commit info: 2014-6-25 15:36:44, bd588a2
Status: UNCONFIRMED → NEW
Ever confirmed: true
Depends on: 1059704
No longer depends on: 1059704
Depends on: 936532
Whiteboard: [Flatfish] → [TCP][flatfish]
Attached file PR for the bug
Attachment #8494894 - Flags: review?(tchevalier)
Attachment #8494894 - Flags: review?(nino.vranesic)
Comment on attachment 8494894 [details] [review] PR for the bug Hi Gauravmittal, thanks for the patch! I have a few general comments, though: Since you are changing existing strings, you need to update their entity names (See https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Changing_existing_strings for reference). Also, Nino nor me are reviewers, you need to pick a peer/owner for the Camera App: David Flanagan, Diego Marcos, Wilson Page, Justin D'Arcangelo (You can find the full list for all apps on the Wiki: https://wiki.mozilla.org/Modules/FirefoxOS ) About the patch itself, sadly we can't just replace “phone” with “device“, see what's been done in bug 944604. Of course that would be a temp fix until bug 936532 is fixed.
Attachment #8494894 - Flags: review?(tchevalier)
Attachment #8494894 - Flags: review?(nino.vranesic)
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: