Closed Bug 1055994 Opened 6 years ago Closed 6 years ago

Fire system message for cell broadcast

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.1)

RESOLVED FIXED
2.1 S3 (29aug)
feature-b2g 2.1

People

(Reporter: steveck, Assigned: bevis)

References

Details

Attachments

(1 file, 2 obsolete files)

In bug 1051792, we plan to create an independent app(network-alert) for handling CMAS in 2.1(and general cell broadcast in the future). But currently there is no system message for cell broadcast now. We will need system message for cell broadcast if we need to handle CMAS in network-alert app.
feature-b2g: --- → 2.1
Flags: needinfo?(htsai)
Hi Steve,

Here is a WIP patch which fires a "cellbroadcast-received" system message with  "cellbroadcast" permission required.
Would you please give it a trial?

Thanks!
Attachment #8476424 - Flags: feedback?(schung)
Thanks for Bevis' help! Bevis, I am assigning to you as you are working on it. :)
Assignee: nobody → btseng
Flags: needinfo?(htsai)
Comment on attachment 8476424 [details] [diff] [review]
WIP: Fire System Message When Receiving Cell Broadcast Message.

This patch does works on emulator, thanks!
Attachment #8476424 - Flags: feedback?(schung) → feedback+
This is to additionally broadcast a "cellbrodcast-received" system message with "cellbroadcast" permission when receiving a CBS message.

Hi Vicamo,

May I have your review for this change which is required to launch additional CMAS app in gaia when cellbroadcast message comes?
BTW, Changes of System App in Gaia is also required to filter out CMAS related CBS messages.

Thanks!
Attachment #8476424 - Attachment is obsolete: true
Attachment #8477150 - Flags: review?(vyang)
Comment on attachment 8477150 [details] [diff] [review]
Patch v1: Broadcast System Message When Receiving Cell Broadcast Message.

Review of attachment 8477150 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +3342,5 @@
> +      body:                  aMessage.fullBody,
> +      messageClass:          aMessage.messageClass,
> +      timestamp:             aMessage.timestamp,
> +      etws:                  etws,
> +      cdmaServiceCategory:   aMessage.serviceCategory

nit: please don't align the values. Just have a space character between property names and values.
Attachment #8477150 - Flags: review?(vyang) → review+
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #5)
> Comment on attachment 8477150 [details] [diff] [review]
> Patch v1: Broadcast System Message When Receiving Cell Broadcast Message.
> 
> Review of attachment 8477150 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/RadioInterfaceLayer.js
> @@ +3342,5 @@
> > +      body:                  aMessage.fullBody,
> > +      messageClass:          aMessage.messageClass,
> > +      timestamp:             aMessage.timestamp,
> > +      etws:                  etws,
> > +      cdmaServiceCategory:   aMessage.serviceCategory
> 
> nit: please don't align the values. Just have a space character between
> property names and values.

Thanks! I'll update the patch again to address this.
Attachment #8477150 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.