1055994 - Fire system message for cell broadcast

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Steve Chung [:steveck]]

In bug 1051792, we plan to create an independent app(network-alert) for handling CMAS in 2.1(and general cell broadcast in the future). But currently there is no system message for cell broadcast now. We will need system message for cell broadcast if we need to handle CMAS in network-alert app.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: WIP: Fire System Message When Receiving Cell Broadcast Message.

Hi Steve,

Here is a WIP patch which fires a "cellbroadcast-received" system message with  "cellbroadcast" permission required.
Would you please give it a trial?

Thanks!

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Thanks for Bevis' help! Bevis, I am assigning to you as you are working on it. :)

Comment 3

[Steve Chung [:steveck]]

Comment on attachment 8476424 [details] [diff] [review]
WIP: Fire System Message When Receiving Cell Broadcast Message.

This patch does works on emulator, thanks!

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch v1: Broadcast System Message When Receiving Cell Broadcast Message.

This is to additionally broadcast a "cellbrodcast-received" system message with "cellbroadcast" permission when receiving a CBS message.

Hi Vicamo,

May I have your review for this change which is required to launch additional CMAS app in gaia when cellbroadcast message comes?
BTW, Changes of System App in Gaia is also required to filter out CMAS related CBS messages.

Thanks!

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8477150 [details] [diff] [review]
Patch v1: Broadcast System Message When Receiving Cell Broadcast Message.

Review of attachment 8477150 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +3342,5 @@
> +      body:                  aMessage.fullBody,
> +      messageClass:          aMessage.messageClass,
> +      timestamp:             aMessage.timestamp,
> +      etws:                  etws,
> +      cdmaServiceCategory:   aMessage.serviceCategory

nit: please don't align the values. Just have a space character between property names and values.

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #5)
> Comment on attachment 8477150 [details] [diff] [review]
> Patch v1: Broadcast System Message When Receiving Cell Broadcast Message.
> 
> Review of attachment 8477150 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/RadioInterfaceLayer.js
> @@ +3342,5 @@
> > +      body:                  aMessage.fullBody,
> > +      messageClass:          aMessage.messageClass,
> > +      timestamp:             aMessage.timestamp,
> > +      etws:                  etws,
> > +      cdmaServiceCategory:   aMessage.serviceCategory
> 
> nit: please don't align the values. Just have a space character between
> property names and values.

Thanks! I'll update the patch again to address this.

Comment 7

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch v2: Broadcast System Message When Receiving Cell Broadcast Message.

address nits in comment 5.

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

update try-server result:
https://tbpl.mozilla.org/?tree=Try&rev=8008c09394c4

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5f24556f8de0

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5f24556f8de0