1051793 - [CMAS] Plug in real CMAS input to the CMAS application

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Network Alerts, defect)

Comment 1

[Julien Wajsberg [:julienw]]

When this bug is completed, we should have a working application that can handle CMAS request from the network.

Comment 2

[Julien Wajsberg [:julienw]]

Something to check here: that we receive the system message when the attention screen is opened. Because of bug 818000 maybe the system message will be ignored if the attention screen is opened and has no system message handler.

Comment 3

[Steve Chung [:steveck]]

Attachment: Link to github

Hi Oleg, it's WIP patch because unit test part is not ready yet, but all functionality should work. Since the emulator is our only way for developing/testing here, you will need to build an emulator build and run ./run-emulator.sh. I'll attach the command for sending the fake cellbroadcast command and you could have a try first. Please feel free to ask if you face any problem while making the emulator build or any concern about the patch, thanks!

Comment 4

[Steve Chung [:steveck]]

Attachment: sending a fake cellbroadcast message

Comment 5

[Kai-Chih Hu [:khu]]

Confirmed with EM/EPM, and this can be landed before FL.

Comment 6

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8478170 [details] [review]
Link to github

Looks good to me! Just few tiny nits on Github.

Thanks!

Comment 7

[Steve Chung [:steveck]]

Comment on attachment 8478170 [details] [review]
Link to github

Hi Oleg, patch updated with more unit test fixed and your suggestion addressed, thanks for the early feedback.

Comment 8

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8478170 [details] [review]
Link to github

Okay, looks great! I've left several minor nits on Github. 

I've also noticed some strange behaviour - when I try to remove "Emergency Alert" notification from notification tray with right swipe, notification tray is automatically closed once notification is removed, it doesn't happen with other notifications (eg. sms or missed call notifications);

Thanks!

Comment 9

[Steve Chung [:steveck]]

Thanks for the detailed review!

In master: d6d2515bd3cc460bfd6c79b2b53bc1d6c18a39ba