1056262 - mercurial-setup is still looking for mqext on bitbucket

Status: RESOLVED DUPLICATE of bug 978514

(Firefox Build System :: Mach Core, enhancement)

Description

[Steve Fink [:sfink] [:s:]]

mqext now lives in version-control-tools

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: mqext now lives in version-control-tools

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8476137 [details] [diff] [review]
mqext now lives in version-control-tools

Review of attachment 8476137 [details] [diff] [review]:
-----------------------------------------------------------------

This patch is busted. Please test with mqext not present in your hgrc to verify it works.

::: tools/mercurial/hgsetup/wizard.py
@@ +278,5 @@
>              self.prompt_external_extension(c, 'firefoxtree', FIREFOXTREE_INFO)
>  
>          if 'mq' in c.extensions:
>              self.prompt_external_extension(c, 'mqext', MQEXT_INFO,
>                                             os.path.join(self.ext_dir, 'mqext'))

We need to kill the last argument to prompt_external_extension().

Comment 3

[Ed Morley [:emorley]]

Oops I've had a patch sitting in my queue for a while to do this, completely forgot to clean it up and file a bug for it :-)

Comment 4

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley] from comment #3)
> Oops I've had a patch sitting in my queue for a while to do this, completely
> forgot to clean it up and file a bug for it :-)

Ah I remember now, I was waiting on bug 978514 comment 5.

Comment 5

[Steve Fink [:sfink] [:s:]]

(In reply to Ed Morley [:edmorley] from comment #3)
> Oops I've had a patch sitting in my queue for a while to do this, completely
> forgot to clean it up and file a bug for it :-)

Excellent, thanks! I'll just wait for that then.

Comment 6

[Jarda Snajdr [:jsnajdr]]

BitBucket changed its SSL certificates on May 6th:

http://blog.bitbucket.org/2015/05/06/bitbuckets-ssl-certificate-is-changing-for-sha-2/

and tools/mercurial/hgsetup/config.py still contains the old fingerprint. So right now 'mach mercurial-setup' cannot set up mgext at all unless you change the fingerprint manually.

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Re comment 6: gps fixed the fingerprint in bug 1164315.

Comment 8

[Ed Morley [:emorley]]

Patch in bug 978514.