1057277 - [Email][Signature] Signature text displayed different with UX specification

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

Description

[Edward Chen[:edchen]]

Attachment: Screenshot

[Blocking Requested - why for this release]:

[Device]
Flame

[Environment]
Gaia      c8e93dadeaec6a2617b4db8b7d65ba14aa8db378
Gecko     https://hg.mozilla.org/mozilla-central/rev/c14e5feadc61
BuildID   20140821160203
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[Actual result]
The sentences displayed to multi line in text field.

[Expected result]
It should be one line, if the texts over 30 words that would add dot at end of line.

[Attachment]
1. The screenshot
2. The UX spec

Comment 1

[Edward Chen[:edchen]]

Attachment: The UX spec

Comment 2

[Alex Wissmann [:awiss]]

Attachment: Patch

Comment 3

[James Burke [:jrburke]]

Comment on attachment 8477571 [details] [review]
Patch

Looks good, tried on device. Once try build is happy then I will merge.

Comment 4

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/a46c0ebe61432bfe69b692adca7613bf422194af

from pull request:
https://github.com/mozilla-b2g/gaia/pull/23219

Comment 5

[James Burke [:jrburke]]

Reverted:
https://github.com/mozilla-b2g/gaia/commit/12f4bffd1aa5347dbedcbc28ef7b242125474a1a

Apparently I goofed when looking at the try output. When I looked at try output it was all green, but apparently the Gij group disappeared, so when I looked again it was back, but red. So I reverted. The issue is that the signature button shows up in two HTML templates not just one. awiss is redoing the fix now, and I will check explicitly for the Gij, as well as run the tests locally.

Comment 6

[Alex Wissmann [:awiss]]

Attachment: Revised Patch

Comment 7

[James Burke [:jrburke]]

Comment on attachment 8477712 [details] [review]
Revised Patch

Waiting for try to finish before merging.

Comment 8

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/596040daa4312d4ba3acddd0dcc5304802ff7617

from pull request:
https://github.com/mozilla-b2g/gaia/pull/23228

Comment 9

[Dylan Oliver [:doliver]]

Clearing blocking flag, already landed in master.

Comment 11

[Edward Chen[:edchen]]

[Environment]
Gaia      1934a2297ffc0d90424cd9cd3294c4a8c74a7333
Gecko     https://hg.mozilla.org/mozilla-central/rev/18901d4f3edd
BuildID   20140825160203
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[Result]
PASS