1057305 - mach bootstrap doesn't support Elementary OS

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Elementary OS is a fork of Ubuntu. Apparently, ./mach bootstrap fails with "NotImplementedError: Bootstrap support for this Linux distro not yet available."

We should fix this.

Comment 1

[Roshan]

I am interested in working on this bug as I use Elementary OS and was stuck on this point while building firefox

Comment 2

[David Teller [:Yoric] - still alive but not very active]

The code lives here: http://dxr.mozilla.org/mozilla-central/source/python/mozboot/mozboot/bootstrap.py#42-66

That's python/mozboot/bootstrap.py in your Firefox source directory.

My guess is that `distro` (defined on line 43) is something other than 'Elementary'.

Bonus points if you modify the exception raised on line 66 to display the value of `distro`.

Comment 3

[Roshan]

Attachment: fix for the bug 1057305

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8477383 [details] [diff] [review]
fix for the bug 1057305

I'm assuming that the previous patch was tested and that some versions of Elementary OS return 'Elementary' while others return '"elementary OS"'. If so, I would rather see `elif distro in ('Elementary', '"elementary OS"'):`

Comment 5

[Roshan]

Attachment: 200946.diff

Changed bootstrap.py to fix the bug which prevented bootstrap.py from running properly on Elementary OS

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8477498 [details] [diff] [review]
200946.diff

Review of attachment 8477498 [details] [diff] [review]:
-----------------------------------------------------------------

Aside from a slightly malformed commit message, this looks good. I'll land it for you.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bef8c1d8b3bd