Closed
Bug 1057305
Opened 10 years ago
Closed 10 years ago
mach bootstrap doesn't support Elementary OS
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: Yoric, Assigned: yoloworkhard7, Mentored)
References
Details
(Whiteboard: [lang=python][good first bug])
Attachments
(1 file, 1 obsolete file)
1.44 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Elementary OS is a fork of Ubuntu. Apparently, ./mach bootstrap fails with "NotImplementedError: Bootstrap support for this Linux distro not yet available." We should fix this.
Reporter | ||
Updated•10 years ago
|
Mentor: dteller
Reporter | ||
Updated•10 years ago
|
Whiteboard: [lang=python][good first bug]
I am interested in working on this bug as I use Elementary OS and was stuck on this point while building firefox
Reporter | ||
Comment 2•10 years ago
|
||
The code lives here: http://dxr.mozilla.org/mozilla-central/source/python/mozboot/mozboot/bootstrap.py#42-66 That's python/mozboot/bootstrap.py in your Firefox source directory. My guess is that `distro` (defined on line 43) is something other than 'Elementary'. Bonus points if you modify the exception raised on line 66 to display the value of `distro`.
Attachment #8477383 -
Flags: review?(gps)
Attachment #8477383 -
Flags: feedback+
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8477383 [details] [diff] [review] fix for the bug 1057305 I'm assuming that the previous patch was tested and that some versions of Elementary OS return 'Elementary' while others return '"elementary OS"'. If so, I would rather see `elif distro in ('Elementary', '"elementary OS"'):`
Attachment #8477383 -
Flags: review?(gps)
Attachment #8477383 -
Flags: feedback+
Updated•10 years ago
|
Product: Firefox → Core
Changed bootstrap.py to fix the bug which prevented bootstrap.py from running properly on Elementary OS
Attachment #8477383 -
Attachment is obsolete: true
Attachment #8477498 -
Flags: review?(gps)
Comment 6•10 years ago
|
||
Comment on attachment 8477498 [details] [diff] [review] 200946.diff Review of attachment 8477498 [details] [diff] [review]: ----------------------------------------------------------------- Aside from a slightly malformed commit message, this looks good. I'll land it for you.
Attachment #8477498 -
Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/bef8c1d8b3bd
Assignee: nobody → yoloworkhard7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•