Closed Bug 1057364 Opened 7 years ago Closed 7 years ago

Failure summary: Reduce line spacing between each log failure line

Categories

(Tree Management :: Treeherder, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: wlach)

References

Details

Attachments

(3 files)

Select a failed job with multiple failure lines that appear in the failure summary - ideally one with no bug suggestions since this shows the problem more (looking for a broken build due to backout being needed, eg https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=e6ddd42718dc)

The log lines that appear have quite a lot of whitespace between each line, meaning fewer lines fit in the same space compared to TBPL.
Summary: Failure summary: Reduce line spacing between each log failure line → Error summary: Reduce line spacing between each log failure line
Blocks: 1059368
Priority: -- → P2
I'll take this one too.
Assignee: nobody → wlachance
Attachment #8480774 - Flags: review?(jeads)
Comment on attachment 8480774 [details] [review]
Reset line height to 1.0

Let me know if this is a sufficient (there are screenshots attached to this bug)
Attachment #8480774 - Flags: feedback?(emorley)
Comment on attachment 8480774 [details] [review]
Reset line height to 1.0

Thank you for working on these :-)
That looks slightly better, but it still seems like we can see less in the panel than we could with TBPL? Sorry to be a pain!
Attachment #8480774 - Flags: feedback?(emorley)
(In reply to Ed Morley [:edmorley] from comment #6)
> Comment on attachment 8480774 [details] [review]
> Reset line height to 1.0
> 
> Thank you for working on these :-)
> That looks slightly better, but it still seems like we can see less in the
> panel than we could with TBPL? Sorry to be a pain!

Ok fixed things a bit more, updated the pull request and accidentally posted the results in the wrong bug (sorry, not my day apparently). :) Are we good now?

https://bugzilla.mozilla.org/show_bug.cgi?id=1057338#c5
Flags: needinfo?(emorley)
Yeah looks good in attachment 8480792 [details].

Thank you :-)
Status: NEW → ASSIGNED
Flags: needinfo?(emorley)
Summary: Error summary: Reduce line spacing between each log failure line → Failure summary: Reduce line spacing between each log failure line
Blocks: 1059375
Comment on attachment 8480774 [details] [review]
Reset line height to 1.0

Looks good to me.
Attachment #8480774 - Flags: review?(jeads) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.