1057364 - Failure summary: Reduce line spacing between each log failure line

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

Select a failed job with multiple failure lines that appear in the failure summary - ideally one with no bug suggestions since this shows the problem more (looking for a broken build due to backout being needed, eg https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=e6ddd42718dc)

The log lines that appear have quite a lot of whitespace between each line, meaning fewer lines fit in the same space compared to TBPL.

Comment 1

[William Lachance (:wlach) (use needinfo!)]

I'll take this one too.

Comment 2

[William Lachance (:wlach) (use needinfo!)]

Attachment: Reset line height to 1.0

Comment 3

[William Lachance (:wlach) (use needinfo!)]

Attachment: What it looked like before

Comment 4

[William Lachance (:wlach) (use needinfo!)]

Attachment: What it looks like after patch

Comment 5

[William Lachance (:wlach) (use needinfo!)]

Comment on attachment 8480774 [details] [review]
Reset line height to 1.0

Let me know if this is a sufficient (there are screenshots attached to this bug)

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8480774 [details] [review]
Reset line height to 1.0

Thank you for working on these :-)
That looks slightly better, but it still seems like we can see less in the panel than we could with TBPL? Sorry to be a pain!

Comment 7

[William Lachance (:wlach) (use needinfo!)]

(In reply to Ed Morley [:edmorley] from comment #6)
> Comment on attachment 8480774 [details] [review]
> Reset line height to 1.0
> 
> Thank you for working on these :-)
> That looks slightly better, but it still seems like we can see less in the
> panel than we could with TBPL? Sorry to be a pain!

Ok fixed things a bit more, updated the pull request and accidentally posted the results in the wrong bug (sorry, not my day apparently). :) Are we good now?

https://bugzilla.mozilla.org/show_bug.cgi?id=1057338#c5

Comment 8

[Ed Morley [:emorley]]

Yeah looks good in attachment 8480792 [details].

Thank you :-)

Comment 9

[Jonathan Eads ( :jeads )]

Comment on attachment 8480774 [details] [review]
Reset line height to 1.0

Looks good to me.

Comment 10

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/20e15c92e12bc7e9d457d07dcf5aa89d21e75a11
Bug 1057364 - Reset line height to 1.0

https://github.com/mozilla/treeherder/commit/0b5a99dbd3c826b946278f195810e6ad7961e42a
Bug 1057364 - Reduce failure summary line padding