Closed
Bug 1057364
Opened 11 years ago
Closed 11 years ago
Failure summary: Reduce line spacing between each log failure line
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: wlach)
References
Details
Attachments
(3 files)
What it looked like before
Select a failed job with multiple failure lines that appear in the failure summary - ideally one with no bug suggestions since this shows the problem more (looking for a broken build due to backout being needed, eg https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=e6ddd42718dc)
The log lines that appear have quite a lot of whitespace between each line, meaning fewer lines fit in the same space compared to TBPL.
|
Reporter | |
Updated•11 years ago
|
Summary: Failure summary: Reduce line spacing between each log failure line → Error summary: Reduce line spacing between each log failure line
|
|
Reporter | |
Updated•11 years ago
|
Priority: -- → P2
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8480774 -
Flags: review?(jeads)
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 8480774 [details] [review]
Reset line height to 1.0
Let me know if this is a sufficient (there are screenshots attached to this bug)
Attachment #8480774 -
Flags: feedback?(emorley)
|
|
Reporter | |
Comment 6•11 years ago
|
||
Comment on attachment 8480774 [details] [review]
Reset line height to 1.0
Thank you for working on these :-)
That looks slightly better, but it still seems like we can see less in the panel than we could with TBPL? Sorry to be a pain!
Attachment #8480774 -
Flags: feedback?(emorley)
|
|
Assignee | |
Comment 7•11 years ago
|
||
(In reply to Ed Morley [:edmorley] from comment #6)
> Comment on attachment 8480774 [details] [review]
> Reset line height to 1.0
>
> Thank you for working on these :-)
> That looks slightly better, but it still seems like we can see less in the
> panel than we could with TBPL? Sorry to be a pain!
Ok fixed things a bit more, updated the pull request and accidentally posted the results in the wrong bug (sorry, not my day apparently). :) Are we good now?
https://bugzilla.mozilla.org/show_bug.cgi?id=1057338#c5
Flags: needinfo?(emorley)
|
|
Reporter | |
Comment 8•11 years ago
|
||
Yeah looks good in attachment 8480792 [details].
Thank you :-)
Status: NEW → ASSIGNED
Flags: needinfo?(emorley)
|
|
Reporter | |
Updated•11 years ago
|
Summary: Error summary: Reduce line spacing between each log failure line → Failure summary: Reduce line spacing between each log failure line
|
|
Reporter | |
Updated•11 years ago
|
Blocks: treeherder-dev-transition
|
||
Comment 9•11 years ago
|
||
Comment on attachment 8480774 [details] [review]
Reset line height to 1.0
Looks good to me.
Attachment #8480774 -
Flags: review?(jeads) → review+
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Comment 10•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/20e15c92e12bc7e9d457d07dcf5aa89d21e75a11
Bug 1057364 - Reset line height to 1.0
https://github.com/mozilla/treeherder/commit/0b5a99dbd3c826b946278f195810e6ad7961e42a
Bug 1057364 - Reduce failure summary line padding
You need to log in
before you can comment on or make changes to this bug.
Description
•