1057529 - Move l10n.js in Settings to no-defer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Spin off of bug 1052256.

We want to achieve DOM translation before firstPaint for non-default locales.

Removing defer attribute from l10n.js script link does the trick and even helps with performance.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Arthur, can you review this?

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Here are the numbers from Flame, master, Settings app:


Default locale:

                       |    master   | no-defer |
================================================|
startup                |  4705       |  4710    |
startup-path-done      |  1807       |  1788    |
mem(app USS)           |  13.965     |  13.906  |
chrome-dom-loaded      |  1194       |  1184    |
chrome-interactive     |  1195       |  1184    |
app-visually-complete  |  2706       |  2748    |
content-interactive    |  2707       |  2749    |
app-loaded             |  4930       |  4921    |


Non default locale:

                       |    master   | no-defer |
================================================|
startup                |  4941       |  4917    |
startup-path-done      |  2020       |  1973    |
mem(app USS)           |  14.139     |  14.174  |
chrome-dom-loaded      |  1412       |  1322    |
chrome-interactive     |  1413       |  1323    |
app-visually-complete  |  2938       |  2893    |
content-interactive    |  2938       |  2893    |
app-loaded             |  5165       |  5130    |


test command: MARIONETTE_RUNNER_HOST=marionette-device-host APP=settings RUNS=31 REPORTER=ConsoleMozPerf make test-perf

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8477619 [details] [review]
pull request

The performance seems not being affected, r=me. Thanks!!

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/4df6ad24968b3823b60adda1a6eb1a164c12029c
Merge: https://github.com/mozilla-b2g/gaia/commit/3d68cd29fb7a27e9092fd3585fb5cd605bbae160

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

There seem to be a significant (above 100ms) performance win in cold_load_time: https://datazilla.mozilla.org/b2g/?branch=master&device=flame-319MB&range=7&test=cold_load_time&app_list=settings&app=settings&gaia_rev=a2abb2920ee11a04&gecko_rev=c7b35bd70fc3&plot=median - unfortunately all more realistic tests are broken on datazilla, so it's hard to say how real the perf win is.