1057555 - (shumway) Implement loadMovieNum() AVM1 API

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect, P3)

Description

[Matt Wobensmith [:mwobensmith][:matt:]]

The following APIs will be needed, most likely, to allow SWFs to load other SWFs:

AVM1:
loadMovie (instance)
loadMovie (_root)
loadMovieNum (0)
loadMovieNum (int)
loadMovieNum (window)

AVM2:
Loader.load (URLRequest)
Loader.loadBytes (byteArray)

Other APIs/mechanisms exist but may or may not be needed to achieve our M3 goal:
loadMovie/loadMovieNum with optional 3rd parameter for data
Runtime shared library (RSL)
HTML-formatted text field
External JS API methods LoadMovie/LoadMovieNum

Comment 1

[Chris Peterson [:cpeterson]]

Yes, we need these for M3.

Comment 2

[Matt Wobensmith [:mwobensmith][:matt:]]

Attachment: swf_load.zip

Media for above basic APIs.

Comment 3

[Till Schneidereit [:till]]

AVM2's Loader.load now seems to fully work. I fixed an issue with the order of events in pull request #1618[1] and added a reftest so it (hopefully) doesn't regress again.

Loader.loadBytes is blocked on [Embed] not working for bytearrays, meaning I cannot write a good test. I'll dig into that next.


[1]: https://github.com/mozilla/shumway/pull/1618

Comment 4

[Till Schneidereit [:till]]

As of PR #1646[1], Loader.loadBytes is also fully implemented. On to AVM1 APIs!

[1]: https://github.com/mozilla/shumway/pull/1646

Comment 5

[Till Schneidereit [:till]]

Yury, do we have the AVM1 APIs fully implemented now? If so, please close. Otherwise, we should implement them for m4.

Comment 6

[Yury Delendik (:yury)]

Not all functions are implemented properly -- we don't support or fully implement level loading functions (loadMovieNum).

Comment 7

[Yury Delendik (:yury)]

loadMovieNum is implemented in https://github.com/mozilla/shumway/pull/2356. For now, closing this bug since it's too broad to catch nuances in the functions/APIs above implementations -- we need to file new bugs with specific examples/test cases.