Closed Bug 1057619 Opened 11 years ago Closed 11 years ago

Node definition in fb_tel_index.js conflicts with browser's Node web API

Categories

(Firefox OS Graveyard :: Gaia, defect)

defect
Not set
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.1 S3 (29aug)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: drs, Assigned: drs)

References

Details

(Whiteboard: [planned-sprint])

Attachments

(1 file)

A Node class is defined here: https://github.com/mozilla-b2g/gaia/blob/master/shared/js/fb/fb_tel_index.js#L8 Though this likely conflicts in more places, it does at the very least here: https://github.com/mozilla-b2g/gaia/blob/master/shared/js/l10n.js#L1493 This class should be renamed.
Assignee: nobody → drs+bugzilla
Status: NEW → ASSIGNED
Whiteboard: [planned-sprint]
Target Milestone: --- → 2.1 S3 (29aug)
BTW, I confirmed that this along with the fix in bug 1051850 fixes bug 1050748.
See Also: → 1057638
Attachment #8477738 - Flags: review?(jmcf) → review?(francisco)
Blocking reason: Check the use case described in 1050748
blocking-b2g: --- → 2.0+
Comment on attachment 8477738 [details] [diff] [review] Rename Node in fb_tel_index to TrieNode, move its test into sharedtest. Great job, thanks Dough!
Attachment #8477738 - Flags: review?(francisco) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: