Create localized default search engine pref for search activity

RESOLVED FIXED in Firefox 34

Status

P1
normal
RESOLVED FIXED
4 years ago
11 months ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

Trunk
Firefox 34
All
Android
Dependency tree / graph

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We'll want to do something similar to what Fennec does, so that we can use a localized preference for the default search engine.

We should also use this as the fallback if we can't find a search plugin that matches the user's search engine pref. After bug 1057629 is fixed, it would be possible to get into this state if the user changes their search engine in the settings, then changes their locale to a new locale that doesn't have that original search engine.
(Assignee)

Updated

4 years ago
Priority: -- → P1
(Assignee)

Comment 1

4 years ago
Created attachment 8480859 [details] [diff] [review]
Use localized string for default search engine identifier

This isn't as fancy as what we do in gecko with region.properties, but this works fine for specifying a default search engine. Localizers need to make sure they use an identifier that's in list.txt, but the searchplugins directory is also localized, so they have control over that (and it's also an issue that exists with the region.properties solution).
Attachment #8480859 - Flags: review?(bnicholson)
Comment on attachment 8480859 [details] [diff] [review]
Use localized string for default search engine identifier

Review of attachment 8480859 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/search/strings/search_strings.dtd
@@ +21,5 @@
>  <!ENTITY search_widget_button_label 'Search'>
>  
> +<!--  Localization note (default_engine_identifier): Search engine identifier for the default
> +      engine. This should be one of the identifiers listed in /searchplugins/list.txt -->
> +<!ENTITY default_engine_identifier 'yahoo'>

This file isn't in a localized region directory (en-US) like most other string files we use. How do localizers change this for their language?
(Assignee)

Comment 3

4 years ago
(In reply to Brian Nicholson (:bnicholson) from comment #2)
> Comment on attachment 8480859 [details] [diff] [review]
> Use localized string for default search engine identifier
> 
> Review of attachment 8480859 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/search/strings/search_strings.dtd
> @@ +21,5 @@
> >  <!ENTITY search_widget_button_label 'Search'>
> >  
> > +<!--  Localization note (default_engine_identifier): Search engine identifier for the default
> > +      engine. This should be one of the identifiers listed in /searchplugins/list.txt -->
> > +<!ENTITY default_engine_identifier 'yahoo'>
> 
> This file isn't in a localized region directory (en-US) like most other
> string files we use. How do localizers change this for their language?

This is bug 1024527.
Comment on attachment 8480859 [details] [diff] [review]
Use localized string for default search engine identifier

Review of attachment 8480859 [details] [diff] [review]:
-----------------------------------------------------------------

OK
Attachment #8480859 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/37a1ea2973dd
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34

Updated

11 months ago
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.