1057634 - Create localized default search engine pref for search activity

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect, P1)

Description

[:Margaret Leibovic]

We'll want to do something similar to what Fennec does, so that we can use a localized preference for the default search engine.

We should also use this as the fallback if we can't find a search plugin that matches the user's search engine pref. After bug 1057629 is fixed, it would be possible to get into this state if the user changes their search engine in the settings, then changes their locale to a new locale that doesn't have that original search engine.

Comment 1

[:Margaret Leibovic]

Attachment: Use localized string for default search engine identifier

This isn't as fancy as what we do in gecko with region.properties, but this works fine for specifying a default search engine. Localizers need to make sure they use an identifier that's in list.txt, but the searchplugins directory is also localized, so they have control over that (and it's also an issue that exists with the region.properties solution).

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8480859 [details] [diff] [review]
Use localized string for default search engine identifier

Review of attachment 8480859 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/search/strings/search_strings.dtd
@@ +21,5 @@
>  <!ENTITY search_widget_button_label 'Search'>
>  
> +<!--  Localization note (default_engine_identifier): Search engine identifier for the default
> +      engine. This should be one of the identifiers listed in /searchplugins/list.txt -->
> +<!ENTITY default_engine_identifier 'yahoo'>

This file isn't in a localized region directory (en-US) like most other string files we use. How do localizers change this for their language?

Comment 3

[:Margaret Leibovic]

(In reply to Brian Nicholson (:bnicholson) from comment #2)
> Comment on attachment 8480859 [details] [diff] [review]
> Use localized string for default search engine identifier
> 
> Review of attachment 8480859 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/search/strings/search_strings.dtd
> @@ +21,5 @@
> >  <!ENTITY search_widget_button_label 'Search'>
> >  
> > +<!--  Localization note (default_engine_identifier): Search engine identifier for the default
> > +      engine. This should be one of the identifiers listed in /searchplugins/list.txt -->
> > +<!ENTITY default_engine_identifier 'yahoo'>
> 
> This file isn't in a localized region directory (en-US) like most other
> string files we use. How do localizers change this for their language?

This is bug 1024527.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8480859 [details] [diff] [review]
Use localized string for default search engine identifier

Review of attachment 8480859 [details] [diff] [review]:
-----------------------------------------------------------------

OK

Comment 5

[:Margaret Leibovic]

https://github.com/mozilla/fennec-search/commit/efb6c97b30efa587499cb602b92fb76ae83f3231
https://hg.mozilla.org/integration/fx-team/rev/37a1ea2973dd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/37a1ea2973dd