Closed Bug 1057849 Opened 10 years ago Closed 10 years ago

addon validation compile time error should keep addon from getting published

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: anaran, Unassigned)

References

()

Details

See: https://addons.mozilla.org/en-US/developers/addon/jot/file/272978/validation#extension-tests Details: JavaScript Compile-Time Error Warning: A compile-time error in the JavaScript halted validation of that file. Message: missing ; before statement resources/jot/lib/main.js 94 95 96 // console.log(exports.main.name + ' of version ' + self.version + ' of addon ' + self.name, options, callbacks); getObjectValues(observableNotifications).forEach(function (name) { I am not sure there is a connection to Bug 776017 here. In my case I forgot to test my addin locally before uploading to AMO. This addon version could never work and it would be great if it were never publishes.
Those errors can happen in cases where the add-on is still functional and acceptable. We minimize the cases where add-ons are automatically rejected because of false positives, so I don't think we can fix this problem.
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Would it at least be possible to list compile time errors as errors instead of warnings? I did not even think to look at the warnings more closely since these are usually coming from use of flagged or non-SDK interface. In this case a fourth of these warnings was actually a compile time error which kept the addon from working at all.
Errors mean the add-on doesn't pass validation and isn't accepted. It's the developer's responsibility to test the add-on before submitting it to our site. It's not our job to detect bugs. In some cases an add-on may pass review without testing, which means you can't rely on us verifying that it works correctly. We only ensure it's safe to use.
(In reply to Jorge Villalobos [:jorgev] from comment #3) > Errors mean the add-on doesn't pass validation and isn't accepted. > > It's the developer's responsibility to test the add-on before submitting it > to our site. It's not our job to detect bugs. In some cases an add-on may > pass review without testing, which means you can't rely on us verifying that > it works correctly. We only ensure it's safe to use. I see. I guess it would help if the validation process with be documented better, but I'd love to be corrected. See also Bug 1058684.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.