1057850 - Play busy tone when the remote party terminates the call setup with busy as reason.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

Play busy tone when the remote party terminates the call setup with busy as reason.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/97

This patch adds the logic the client need for playing the busy tone once the the remote party terminates the call setup with busy as reason. Actually the patch is finishes and this request could be a review one but I prefer to hear from you first.

Victoria, we are going to play a busy tone in case the call is rejected because the remote party is busy. Are we going to show a new screen informing the user the remote party is busy?

Comment 2

[Borja Salguero [:borjasalguero]]

Comment on attachment 8478277 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/97

Some comments to address. Please ask me to review this again when ready! Thanks!

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 8478277 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/97

Just a easy-to-fix comment and let's merge this! Thanks!

Comment 4

[Victoria Gerchinhoren [:vicky]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #1)
> Created attachment 8478277 [details] [review]
> Pointer to Github PR
> https://github.com/mozilla-b2g/firefoxos-loop-client/pull/97
> 
> This patch adds the logic the client need for playing the busy tone once the
> the remote party terminates the call setup with busy as reason. Actually the
> patch is finishes and this request could be a review one but I prefer to
> hear from you first.
> 
> Victoria, we are going to play a busy tone in case the call is rejected
> because the remote party is busy. Are we going to show a new screen
> informing the user the remote party is busy?

Yes, please when busy, the word "connecting" of the outgoing screen will be replaced by the word "busy" and last still 1 or 2 seconds so the user can notice it.

Thanks!

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Victoria Gerchinhoren [:vicky] from comment #4)
> > Victoria, we are going to play a busy tone in case the call is rejected
> > because the remote party is busy. Are we going to show a new screen
> > informing the user the remote party is busy?
> 
> Yes, please when busy, the word "connecting" of the outgoing screen will be
> replaced by the word "busy" and last still 1 or 2 seconds so the user can
> notice it.

Done, thanks! Let's leave bug 1054417 for something more advanced we can add in the future.

(In reply to Borja Salguero [:borjasalguero] from comment #3)
> Comment on attachment 8478277 [details] [review]
> Pointer to Github PR
> https://github.com/mozilla-b2g/firefoxos-loop-client/pull/97
> 
> Just a easy-to-fix comment and let's merge this! Thanks!

Thanks Borja, landed at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/4097cce0742fc5fbe7e02cbdadc8b1ce41550871