Closed Bug 1057877 Opened 5 years ago Closed 5 years ago

Don't expect canPlayType('video/mp4') on MacOS X 10.6

Categories

(Core :: Audio/Video, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file, 1 obsolete file)

test_can_play_type_mpeg.html now expects mp4 to work if media.fragmented-mp4.exposed is true, but enabling the pref doesn't result in playback support on Mac OS X 10.6, where the VideoToolbox platform api we use isn't available. So the test works on 10.8 but not 10.6.
Assignee: nobody → giles
Blocks: 1043696
Depends on: 1056232
OS: Linux → Mac OS X
Add a version check like we use on windows.
Attachment #8478019 - Flags: review?(cpearce)
Comment on attachment 8478019 [details] [diff] [review]
Account for mp4 playback failing on MacOS X 10.6

Review of attachment 8478019 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/test/test_can_play_type_mpeg.html
@@ +55,4 @@
>  var haveMp4 = (getPref("media.windows-media-foundation.enabled") && IsWindowsVistaOrLater()) ||
>                 getPref("media.omx.enabled") ||
>                 getPref("media.gstreamer.enabled") ||
> +               getPref("media.fragmented-mp4.exposed") &&

Sorry, I bitrot you when I landed bug 1057880 on m-i earlier today. How about we create a IsMP4ReaderAvailable() function which encapsulates the checks you and I need to do into a single function?
Rebase on top of the changes in bug 1057880.

- Move fmp4-related checks to their own function.
- Remove IsWindowsXPOrEarlier since it's just the inverse of IsWindowsVistaOrLater.
- Handle Mac regex not matching at all.
- Improve Windows regex.
Attachment #8478019 - Attachment is obsolete: true
Attachment #8478019 - Flags: review?(cpearce)
Attachment #8478549 - Flags: review?(cpearce)
Attachment #8478549 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/d8c1c88cde24
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.