1057877 - Don't expect canPlayType('video/mp4') on MacOS X 10.6

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

test_can_play_type_mpeg.html now expects mp4 to work if media.fragmented-mp4.exposed is true, but enabling the pref doesn't result in playback support on Mac OS X 10.6, where the VideoToolbox platform api we use isn't available. So the test works on 10.8 but not 10.6.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Account for mp4 playback failing on MacOS X 10.6

Add a version check like we use on windows.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8478019 [details] [diff] [review]
Account for mp4 playback failing on MacOS X 10.6

Review of attachment 8478019 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/test/test_can_play_type_mpeg.html
@@ +55,4 @@
>  var haveMp4 = (getPref("media.windows-media-foundation.enabled") && IsWindowsVistaOrLater()) ||
>                 getPref("media.omx.enabled") ||
>                 getPref("media.gstreamer.enabled") ||
> +               getPref("media.fragmented-mp4.exposed") &&

Sorry, I bitrot you when I landed bug 1057880 on m-i earlier today. How about we create a IsMP4ReaderAvailable() function which encapsulates the checks you and I need to do into a single function?

Comment 3

[Ralph Giles (:rillian)]

Attachment: Account for fmp4 playback failing on MacOS X 10.6.

Rebase on top of the changes in bug 1057880.

- Move fmp4-related checks to their own function.
- Remove IsWindowsXPOrEarlier since it's just the inverse of IsWindowsVistaOrLater.
- Handle Mac regex not matching at all.
- Improve Windows regex.

Comment 4

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8c1c88cde24

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d8c1c88cde24