Closed
Bug 1057911
Opened 10 years ago
Closed 10 years ago
libav/ffmpeg not draining
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: ajones, Assigned: jya)
References
()
Details
Attachments
(1 file, 2 obsolete files)
5.90 KB,
patch
|
Details | Diff | Splinter Review |
Steps to reproduce: 1. Enable ffmpeg/libav backend 2. Navigate to given URL Expected results: Video should run through to 6.00 seconds Actual results: Video runs through to 5.18 seconds
Reporter | ||
Comment 1•10 years ago
|
||
Attachment #8478054 -
Flags: review?(jyavenard)
Reporter | ||
Updated•10 years ago
|
Summary: libav/ffmpeg not flushing → libav/ffmpeg not draining
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8478054 [details] [diff] [review] Fix libav/ffmpeg drain Review of attachment 8478054 [details] [diff] [review]: ----------------------------------------------------------------- The code isn't strictly equivalent to what was done before (how mCallback->InputExhausted(); was called) ::: content/media/fmp4/ffmpeg/FFmpegH264Decoder.cpp @@ +129,1 @@ > For equivalence with the earlier code, DoDecodeFrame return value should be tested and abort early if needed. If so, however we need to distinguish between an error and avcodec_decode_video2 not returning a frame. Both conditions would return false but the later isn't an error
Attachment #8478054 -
Flags: review?(jyavenard)
Reporter | ||
Comment 3•10 years ago
|
||
Attachment #8478801 -
Flags: review?(jyavenard)
Reporter | ||
Updated•10 years ago
|
Attachment #8478054 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8478801 -
Flags: review?(jyavenard) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Update patch for latest tip
Assignee | ||
Updated•10 years ago
|
Attachment #8478801 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Assignee: ajones → jyavenard
Status: NEW → ASSIGNED
Reporter | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d3e70bda517
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5d3e70bda517
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•