1057911 - libav/ffmpeg not draining

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Steps to reproduce:

1. Enable ffmpeg/libav backend
2. Navigate to given URL

Expected results:

Video should run through to 6.00 seconds

Actual results:

Video runs through to 5.18 seconds

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix libav/ffmpeg drain

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8478054 [details] [diff] [review]
Fix libav/ffmpeg drain

Review of attachment 8478054 [details] [diff] [review]:
-----------------------------------------------------------------

The code isn't strictly equivalent to what was done before (how mCallback->InputExhausted(); was called)

::: content/media/fmp4/ffmpeg/FFmpegH264Decoder.cpp
@@ +129,1 @@
>  

For equivalence with the earlier code, DoDecodeFrame return value should be tested and abort early if needed.

If so, however we need to distinguish between an error and avcodec_decode_video2 not returning a frame. Both conditions would return false but the later isn't an error

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix libav/ffmpeg drain

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Fix libav/ffmpeg drain

Update patch for latest tip

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d3e70bda517

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5d3e70bda517