1058101 - Flatten away public/src subdirectories under dom/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/activities/src/ into parent directory

Comment 2

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/apps/src/ into parent directory

Comment 3

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/cellbroadcast/src/ into parent directory

Comment 4

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/downloads/src/ into parent directory

Comment 5

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/icc/src/ into parent directory

Comment 6

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/mobileconnection/src/ into parent directory

Comment 7

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/mobileid/src/ into parent directory

Comment 8

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/mobilemessage/src/ into parent directory

Comment 9

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/network/src/ into parent directory

Comment 10

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/push/src/ into parent directory

Comment 11

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/wappush/src/ into parent directory

Comment 12

[Andrew McCreight [:mccr8]]

smaug said it was okay for me to review these over IRC.

Comment 13

[Andrew McCreight [:mccr8]]

I assume these don't really need build peer review, gps?  They are mostly just mashing the moz.build files from a subdirectory into the main directory.

Comment 14

[Gregory Szorc [:gps]]

Squashing directories via moz.build-only changes should not require build peer review, especially if those directories don't have Makefile.in files.

Comment 15

[Andrew McCreight [:mccr8]]

Comment on attachment 8478400 [details] [diff] [review]
Flatten dom/mobilemessage/src/ into parent directory

Review of attachment 8478400 [details] [diff] [review]:
-----------------------------------------------------------------

There are some references to a file in this directory in a couple of comments in some GeckoSmsManager.java files:
http://mxr.mozilla.org/mozilla-central/search?string=dom/mobilemessage/src&filter=[Dd]om/mobilemessage/src
Those should probably be updated, and the changes given a rubberstamp review from whoever is responsible for those files.
(I did a little checking for the previous dirs and nothing showed up.)

Comment 16

[Andrew McCreight [:mccr8]]

Comment on attachment 8478404 [details] [diff] [review]
Flatten dom/wappush/src/ into parent directory

Review of attachment 8478404 [details] [diff] [review]:
-----------------------------------------------------------------

Please remember to touch the clobber file when landing.

Comment 17

[Andrew McCreight [:mccr8]]

And thanks for doing all this cleanup work!

Comment 18

[Biru Mohanathas [:poiru]]

Attachment: Move dom/src/geolocation/ into dom/

Comment 19

[Biru Mohanathas [:poiru]]

Attachment: Move dom/src/json/ into dom/

Comment 20

[Biru Mohanathas [:poiru]]

Attachment: Move dom/src/jsurl/ into dom/

Comment 21

[Biru Mohanathas [:poiru]]

Attachment: Move dom/src/notification/ into dom/

Comment 22

[Biru Mohanathas [:poiru]]

Attachment: Move dom/src/offline/ into dom/

Comment 23

[Biru Mohanathas [:poiru]]

Attachment: Move dom/src/storage/ into dom/

Comment 24

[Biru Mohanathas [:poiru]]

Attachment: Flatten dom/src/ into parent diredctory

Comment 25

[Andrew McCreight [:mccr8]]

Comment on attachment 8481422 [details] [diff] [review]
Move dom/src/json/ into dom/

Review of attachment 8481422 [details] [diff] [review]:
-----------------------------------------------------------------

Waldo, these JSON files refer to a directory that is being moved, but it looks like the comment was added 3 years ago when you moved these, in bug 636175.  Should we just delete these comments?  I don't think they serve any useful purpose at this point.

Comment 26

[Jeff Walden [:Waldo]]

Comment on attachment 8481422 [details] [diff] [review]
Move dom/src/json/ into dom/

Yeah, the comments can just be removed.

Comment 27

[Biru Mohanathas [:poiru]]

Attachment: Move dom/src/json/ into dom/

(In reply to Andrew McCreight [:mccr8] from comment #25)
> Waldo, these JSON files refer to a directory that is being moved, but it
> looks like the comment was added 3 years ago when you moved these, in bug
> 636175.  Should we just delete these comments?  I don't think they serve any
> useful purpose at this point.

Comments removed.

Comment 28

[Andrew McCreight [:mccr8]]

Comment on attachment 8481543 [details] [diff] [review]
Move dom/src/json/ into dom/

Review of attachment 8481543 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 29

[Andrew McCreight [:mccr8]]

Comment on attachment 8481428 [details] [diff] [review]
Flatten dom/src/ into parent diredctory

Review of attachment 8481428 [details] [diff] [review]:
-----------------------------------------------------------------

nit: diredctory -> directory in the patch description

Comment 30

[Biru Mohanathas [:poiru]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e788a13ab210
https://hg.mozilla.org/integration/mozilla-inbound/rev/27c608247d1d
https://hg.mozilla.org/integration/mozilla-inbound/rev/9eb64d608e95
https://hg.mozilla.org/integration/mozilla-inbound/rev/55629555112d
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6b1c86890ed
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f5efe10c3c1
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf7e72e6455c
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbc8333984a3
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bfbf136a398
https://hg.mozilla.org/integration/mozilla-inbound/rev/e013edc6ea0d
https://hg.mozilla.org/integration/mozilla-inbound/rev/1db55321cc1a
https://hg.mozilla.org/integration/mozilla-inbound/rev/eecdde427cb7
https://hg.mozilla.org/integration/mozilla-inbound/rev/73bbfa0bebc7
https://hg.mozilla.org/integration/mozilla-inbound/rev/3795c155428d
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9de02fab540
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a92119a2bb1
https://hg.mozilla.org/integration/mozilla-inbound/rev/f69cb38a847a
https://hg.mozilla.org/integration/mozilla-inbound/rev/d82866049064

Comment 31

[Biru Mohanathas [:poiru]]

Oh, and try push: https://tbpl.mozilla.org/?tree=Try&rev=eddab6545afb

Comment 32

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e788a13ab210
https://hg.mozilla.org/mozilla-central/rev/27c608247d1d
https://hg.mozilla.org/mozilla-central/rev/9eb64d608e95
https://hg.mozilla.org/mozilla-central/rev/55629555112d
https://hg.mozilla.org/mozilla-central/rev/f6b1c86890ed
https://hg.mozilla.org/mozilla-central/rev/1f5efe10c3c1
https://hg.mozilla.org/mozilla-central/rev/cf7e72e6455c
https://hg.mozilla.org/mozilla-central/rev/dbc8333984a3
https://hg.mozilla.org/mozilla-central/rev/9bfbf136a398
https://hg.mozilla.org/mozilla-central/rev/e013edc6ea0d
https://hg.mozilla.org/mozilla-central/rev/1db55321cc1a
https://hg.mozilla.org/mozilla-central/rev/eecdde427cb7
https://hg.mozilla.org/mozilla-central/rev/73bbfa0bebc7
https://hg.mozilla.org/mozilla-central/rev/3795c155428d
https://hg.mozilla.org/mozilla-central/rev/a9de02fab540
https://hg.mozilla.org/mozilla-central/rev/1a92119a2bb1
https://hg.mozilla.org/mozilla-central/rev/f69cb38a847a
https://hg.mozilla.org/mozilla-central/rev/d82866049064