Flatten away public/src subdirectories under dom/

RESOLVED FIXED in mozilla34

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: poiru, Assigned: poiru)

Tracking

Trunk
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(18 attachments, 1 obsolete attachment)

3.88 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
6.43 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
1.95 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
2.27 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
2.54 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
4.81 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
1.82 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
15.83 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
10.70 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
1.94 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
2.63 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
6.40 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
7.01 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
4.01 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
3.78 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
6.50 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
1.84 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
10.29 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8478392 [details] [diff] [review]
Flatten dom/activities/src/ into parent directory
Attachment #8478392 - Flags: review?(continuation)
(Assignee)

Comment 2

4 years ago
Created attachment 8478393 [details] [diff] [review]
Flatten dom/apps/src/ into parent directory
Attachment #8478393 - Flags: review?(continuation)
(Assignee)

Comment 3

4 years ago
Created attachment 8478394 [details] [diff] [review]
Flatten dom/cellbroadcast/src/ into parent directory
Attachment #8478394 - Flags: review?(continuation)
(Assignee)

Comment 4

4 years ago
Created attachment 8478395 [details] [diff] [review]
Flatten dom/downloads/src/ into parent directory
Attachment #8478395 - Flags: review?(continuation)
(Assignee)

Comment 5

4 years ago
Created attachment 8478397 [details] [diff] [review]
Flatten dom/icc/src/ into parent directory
Attachment #8478397 - Flags: review?(continuation)
(Assignee)

Comment 6

4 years ago
Created attachment 8478398 [details] [diff] [review]
Flatten dom/mobileconnection/src/ into parent directory
Attachment #8478398 - Flags: review?(continuation)
(Assignee)

Comment 7

4 years ago
Created attachment 8478399 [details] [diff] [review]
Flatten dom/mobileid/src/ into parent directory
Attachment #8478399 - Flags: review?(continuation)
(Assignee)

Comment 8

4 years ago
Created attachment 8478400 [details] [diff] [review]
Flatten dom/mobilemessage/src/ into parent directory
Attachment #8478400 - Flags: review?(continuation)
(Assignee)

Comment 9

4 years ago
Created attachment 8478401 [details] [diff] [review]
Flatten dom/network/src/ into parent directory
Attachment #8478401 - Flags: review?(continuation)
(Assignee)

Comment 10

4 years ago
Created attachment 8478403 [details] [diff] [review]
Flatten dom/push/src/ into parent directory
Attachment #8478403 - Flags: review?(continuation)
(Assignee)

Comment 11

4 years ago
Created attachment 8478404 [details] [diff] [review]
Flatten dom/wappush/src/ into parent directory
Attachment #8478404 - Flags: review?(continuation)
smaug said it was okay for me to review these over IRC.
Attachment #8478392 - Flags: review?(continuation) → review+
I assume these don't really need build peer review, gps?  They are mostly just mashing the moz.build files from a subdirectory into the main directory.
Flags: needinfo?(gps)
Attachment #8478393 - Flags: review?(continuation) → review+
Attachment #8478394 - Flags: review?(continuation) → review+
Attachment #8478395 - Flags: review?(continuation) → review+
Attachment #8478397 - Flags: review?(continuation) → review+
Attachment #8478398 - Flags: review?(continuation) → review+
Attachment #8478399 - Flags: review?(continuation) → review+
Squashing directories via moz.build-only changes should not require build peer review, especially if those directories don't have Makefile.in files.
Flags: needinfo?(gps)
Comment on attachment 8478400 [details] [diff] [review]
Flatten dom/mobilemessage/src/ into parent directory

Review of attachment 8478400 [details] [diff] [review]:
-----------------------------------------------------------------

There are some references to a file in this directory in a couple of comments in some GeckoSmsManager.java files:
http://mxr.mozilla.org/mozilla-central/search?string=dom/mobilemessage/src&filter=[Dd]om/mobilemessage/src
Those should probably be updated, and the changes given a rubberstamp review from whoever is responsible for those files.
(I did a little checking for the previous dirs and nothing showed up.)
Attachment #8478400 - Flags: review?(continuation) → review+
Attachment #8478401 - Flags: review?(continuation) → review+
Attachment #8478403 - Flags: review?(continuation) → review+
Comment on attachment 8478404 [details] [diff] [review]
Flatten dom/wappush/src/ into parent directory

Review of attachment 8478404 [details] [diff] [review]:
-----------------------------------------------------------------

Please remember to touch the clobber file when landing.
Attachment #8478404 - Flags: review?(continuation) → review+
And thanks for doing all this cleanup work!
(Assignee)

Comment 18

4 years ago
Created attachment 8481421 [details] [diff] [review]
Move dom/src/geolocation/ into dom/
Attachment #8481421 - Flags: review?(continuation)
(Assignee)

Comment 19

4 years ago
Created attachment 8481422 [details] [diff] [review]
Move dom/src/json/ into dom/
Attachment #8481422 - Flags: review?(continuation)
(Assignee)

Comment 20

4 years ago
Created attachment 8481423 [details] [diff] [review]
Move dom/src/jsurl/ into dom/
Attachment #8481423 - Flags: review?(continuation)
(Assignee)

Comment 21

4 years ago
Created attachment 8481424 [details] [diff] [review]
Move dom/src/notification/ into dom/
Attachment #8481424 - Flags: review?(continuation)
(Assignee)

Comment 22

4 years ago
Created attachment 8481425 [details] [diff] [review]
Move dom/src/offline/ into dom/
Attachment #8481425 - Flags: review?(continuation)
(Assignee)

Comment 23

4 years ago
Created attachment 8481427 [details] [diff] [review]
Move dom/src/storage/ into dom/
Attachment #8481427 - Flags: review?(continuation)
(Assignee)

Comment 24

4 years ago
Created attachment 8481428 [details] [diff] [review]
Flatten dom/src/ into parent diredctory
Attachment #8481428 - Flags: review?(continuation)
Attachment #8481421 - Flags: review?(continuation) → review+
Comment on attachment 8481422 [details] [diff] [review]
Move dom/src/json/ into dom/

Review of attachment 8481422 [details] [diff] [review]:
-----------------------------------------------------------------

Waldo, these JSON files refer to a directory that is being moved, but it looks like the comment was added 3 years ago when you moved these, in bug 636175.  Should we just delete these comments?  I don't think they serve any useful purpose at this point.
Attachment #8481422 - Flags: feedback?(jwalden+bmo)
Attachment #8481423 - Flags: review?(continuation) → review+
Attachment #8481424 - Flags: review?(continuation) → review+
Comment on attachment 8481422 [details] [diff] [review]
Move dom/src/json/ into dom/

Yeah, the comments can just be removed.
Attachment #8481422 - Flags: feedback?(jwalden+bmo) → feedback+
(Assignee)

Comment 27

4 years ago
Created attachment 8481543 [details] [diff] [review]
Move dom/src/json/ into dom/

(In reply to Andrew McCreight [:mccr8] from comment #25)
> Waldo, these JSON files refer to a directory that is being moved, but it
> looks like the comment was added 3 years ago when you moved these, in bug
> 636175.  Should we just delete these comments?  I don't think they serve any
> useful purpose at this point.

Comments removed.
Attachment #8481422 - Attachment is obsolete: true
Attachment #8481422 - Flags: review?(continuation)
Attachment #8481543 - Flags: review?(continuation)
Comment on attachment 8481543 [details] [diff] [review]
Move dom/src/json/ into dom/

Review of attachment 8481543 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8481543 - Flags: review?(continuation) → review+
Attachment #8481425 - Flags: review?(continuation) → review+
Attachment #8481427 - Flags: review?(continuation) → review+
Comment on attachment 8481428 [details] [diff] [review]
Flatten dom/src/ into parent diredctory

Review of attachment 8481428 [details] [diff] [review]:
-----------------------------------------------------------------

nit: diredctory -> directory in the patch description
Attachment #8481428 - Flags: review?(continuation) → review+
You need to log in before you can comment on or make changes to this bug.