Closed
Bug 1060865
Opened 10 years ago
Closed 10 years ago
SMS filtering with startDate/endDate broken
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox32 | --- | wontfix |
firefox33 | --- | wontfix |
firefox34 | --- | fixed |
b2g-v2.1 | --- | fixed |
b2g-v2.2 | --- | unaffected |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Keywords: regression, Whiteboard: [systemsfe])
Attachments
(2 files, 1 obsolete file)
1.37 KB,
text/plain
|
Details | |
1.23 KB,
patch
|
gerard-majax
:
review+
|
Details | Diff | Splinter Review |
After bug 878533 landed, my patch (bug 887198 attachment 8475080 [details] [diff] [review]) for limiting the amount of requested messages to only the last month broke. As far as I could analyze, on Gecko side in MobileMessageDB I'm getting invalid/shifted values for the filter content. If I specify both startDate and endDate: > 08-30 23:38:03.995 1862 1862 I Gecko : MobileMessageDB: Creating a message cursor. Filters: startDate: 1409434683453 endDate: 52614631488 delivery: null numbers: (null) read: (null) threadId: 3 reverse: true If I specify only startDate: > 08-30 23:37:23.643 1862 1862 I Gecko : MobileMessageDB: Creating a message cursor. Filters: startDate: 0 endDate: (null) delivery: null numbers: (null) read: (null) threadId: 3 reverse: true Please note the behavior of startDate and endDate in those logs: - when we specify both, the startDate values is in fact the current timestamp, and endDate just makes no sense - when we specify only startDate, its value is 0 and the endDate stays null
Assignee | ||
Comment 1•10 years ago
|
||
Log from MobileMessageManager.cpp, just before the dbService->CreateMessageCursor() call: > 08-31 00:14:36.841 4476 4476 I Gecko : Calling: CreateMessageCursor: hasStartDate=1 > 08-31 00:14:36.841 4476 4476 I Gecko : Calling: CreateMessageCursor: startDate=1407017676782 > 08-31 00:14:36.841 4476 4476 I Gecko : Calling: CreateMessageCursor: hasEndDate=1 > 08-31 00:14:36.841 4476 4476 I Gecko : Calling: CreateMessageCursor: endDate=1409436876782 Log from MobileMessageDB: > 08-31 00:14:36.849 4187 4187 I Gecko : MobileMessageDB: Creating a message cursor. Filters: startDate: 1409436876782 endDate: 13730751496340730000 delivery: null numbers: (null) read: (null) threadId: 3 reverse: true
Assignee | ||
Comment 2•10 years ago
|
||
With this patch applied, I can see the following: > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: CreateMessageCursor: hasStartDate=1 > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: CreateMessageCursor: startDate=1407019168633 > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: CreateMessageCursor: hasEndDate=1 > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: CreateMessageCursor: endDate=1409438368633 > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: IPCCreateMessageCursor: aHasStartDate=1 > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: IPCCreateMessageCursor: aStartDate=1407019168633 > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: IPCCreateMessageCursor: aHasEndDate=1 > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: IPCCreateMessageCursor: aEndDate=1409438368633 > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: SmsFilterData CreateMessageCursor: hasStartDate=1 > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: SmsFilterData CreateMessageCursor: startDate=1409438368633 > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: SmsFilterData CreateMessageCursor: hasEndDate=1 > 08-31 00:39:28.695 4918 4918 I Gecko : Calling: SmsFilterData CreateMessageCursor: endDate=4615148482524188380 So it would look like the assignments at http://dxr.mozilla.org/mozilla-central/source/dom/mobilemessage/src/ipc/SmsIPCService.cpp#238 are triggering the issue: values passed to the method are okay.
Assignee | ||
Comment 3•10 years ago
|
||
Oh god. That was SO obvious: > data.startDate() = aStartDate; http://dxr.mozilla.org/mozilla-central/source/dom/mobilemessage/src/ipc/SmsIPCService.cpp#239 And then: > data.startDate() = aEndDate; http://dxr.mozilla.org/mozilla-central/source/dom/mobilemessage/src/ipc/SmsIPCService.cpp#241
Assignee | ||
Comment 4•10 years ago
|
||
[Blocking Requested - why for this release]: API broken
Assignee: nobody → lissyx+mozillians
blocking-b2g: --- → 2.1?
Assignee | ||
Updated•10 years ago
|
Component: Gaia::SMS → DOM
Product: Firefox OS → Core
Assignee | ||
Comment 5•10 years ago
|
||
Copying the endDate value in the startDate field won't make the filter working properly ; in fact, it will even crash the Messages app sometimes because of the uninitialized value of the endDate which is invalid and triggers a DataError within the MobileMessageDB.
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8481902 [details] [diff] [review] Fix end date filling in SmsFilter Vicamo, please find attached a patch that fixes the issue. I ran a try run against B2G Emulator ICS with Marionette, https://tbpl.mozilla.org/?tree=Try&rev=fd9affb28c5a&showall=1 it seems to be green but I don't see any marionette tests being ran.
Attachment #8481902 -
Flags: review?(vyang)
Comment 7•10 years ago
|
||
Comment on attachment 8481902 [details] [diff] [review] Fix end date filling in SmsFilter Review of attachment 8481902 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for that mistake :(
Attachment #8481902 -
Flags: review?(vyang) → review+
Updated•10 years ago
|
Component: DOM → DOM: Device Interfaces
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 8•10 years ago
|
||
Copying the endDate value in the startDate field won't make the filter working properly ; in fact, it will even crash the Messages app sometimes because of the uninitialized value of the endDate which is invalid and triggers a DataError within the MobileMessageDB.
Assignee | ||
Comment 9•10 years ago
|
||
I had to rebase this patch because bug 1058101 landed and moved all the files ...
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8482151 [details] [diff] [review] Fix end date filling in SmsFilter Carrying r+ from vicamo
Attachment #8482151 -
Flags: review+
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8481902 [details] [diff] [review] Fix end date filling in SmsFilter Obsolete because of bug 1058101
Attachment #8481902 -
Attachment is obsolete: true
Comment 12•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fb36560d80c
Keywords: checkin-needed
Comment 13•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7fb36560d80c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•10 years ago
|
Whiteboard: [systemsfe]
Updated•10 years ago
|
blocking-b2g: 2.1? → 2.1+
Updated•10 years ago
|
status-b2g-v2.1:
--- → fixed
status-firefox32:
--- → wontfix
status-firefox33:
--- → wontfix
status-firefox34:
--- → fixed
Updated•10 years ago
|
status-b2g-v2.2:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•