Closed Bug 1058258 Opened 5 years ago Closed 5 years ago

Fix typos and improve some of the Loop text

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
Points:
1

Tracking

(firefox34 verified)

VERIFIED FIXED
mozilla34
Iteration:
34.3
Tracking Status
firefox34 --- verified

People

(Reporter: jaws, Assigned: jaws)

Details

Attachments

(1 file, 2 obsolete files)

share_email_body currently reads:
Please click that link to call me back:\r\n\r\n{{callUrl}}

"click that link" is poor grammar, "click this link" would be more appropriate.

I'm also not sure if it makes sense to say "call me back", since this is not always sent in response to a missed call. Therefore, I think the should be changed to:
Please click this link to call me:\r\n\r\n{{callUrl}}
Flags: firefox-backlog+
Attached patch Patch (obsolete) — Splinter Review
Attachment #8478568 - Flags: review?(adam)
Attached patch Patch v1.1 (obsolete) — Splinter Review
Revved the string ID.
Attachment #8478568 - Attachment is obsolete: true
Attachment #8478568 - Flags: review?(adam)
Attachment #8478573 - Flags: review?(adam)
Flags: qe-verify+
QA Contact: anthony.s.hughes
Summary: share_email_body text can be improved → Fix typos and improve some of the Loop text
Comment on attachment 8478573 [details] [diff] [review]
Patch v1.1

Review of attachment 8478573 [details] [diff] [review]:
-----------------------------------------------------------------

As best as I understand localization procedures, this looks good to me.
Attachment #8478573 - Flags: review?(adam) → review+
Attached patch Patch v2Splinter Review
Noticed some other things that should be fixed:
> Hangup -> Hang up
hangup is not a word, the proper idiom is two separate words. Since this does not change the context, the string ID was not revved.
> Unute -> Unmute
Typo, since this does not change the context, the string ID was not revved.
> Your peer has ended the conversation. -> The person you were calling has ended the conversation.
"Peer" is a highly technical term, and is not often used when discussing calling another person. I have changed this text to be closer to what someone may say when the person on the other end of the line hangs up. I revved the string ID for this as it changes the context and localizers should translate the newer text.
Attachment #8478573 - Attachment is obsolete: true
Attachment #8478609 - Flags: review?(adam)
Comment on attachment 8478609 [details] [diff] [review]
Patch v2

Review of attachment 8478609 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +65,1 @@
>  ## part between {{..}} and let the \r\n\r\n part

This comment is a bit confusing -- perhaps "leave the \r\n\r\n part alone"?
Attachment #8478609 - Flags: review?(adam) → review+
https://hg.mozilla.org/mozilla-central/rev/c7ee261eed1b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla34
(In reply to Wes Kocher (:KWierso) from comment #7)
> https://hg.mozilla.org/mozilla-central/rev/c7ee261eed1b

I'm not sure this made it into today's Nightly -- for example I'm still seeing "Your peer ended the conversation."
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> > Hangup -> Hang up
> > Unute -> Unmute
> > Your peer has ended the conversation. -> The person you were calling has ended the conversation.
Still broken for the person who initiates the call, fixed on the client side
Flags: needinfo?(jaws)
(In reply to Paul Silaghi, QA [:pauly] from comment #9)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> > > Hangup -> Hang up
> > > Unute -> Unmute
> > > Your peer has ended the conversation. -> The person you were calling has ended the conversation.
> Still broken for the person who initiates the call, fixed on the client side

It will be as it hasn't been deployed yet (bug 1063403).

Alternately you can test on the dev server (which gets updated within an hour of a patch landing in mozilla-central):

https://wiki.mozilla.org/CloudServices/Loop/Deploy#Dev
Flags: needinfo?(jaws)
(In reply to Mark Banner (:standard8) from comment #10)
> It will be as it hasn't been deployed yet (bug 1063403).
Verified fixed 34.0a2 (2014-09-07) Win 7 x64
Status: RESOLVED → VERIFIED
QA Contact: anthony.s.hughes → paul.silaghi
You need to log in before you can comment on or make changes to this bug.