Closed Bug 1058360 Opened 5 years ago Closed 5 years ago

JS Test protocol throwing errors due to normalizedName being incorrect

Categories

(Chat Core :: General, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

References

Details

Attachments

(1 file, 2 obsolete files)

Timestamp: 8/25/14, 9:48:40 PM
Error: uncaught exception: Creating an instance of prpl-jstest but this object implements prpl-js test

Timestamp: 8/25/14, 9:48:40 PM
Error: Could not initialize protocol prpl-jstest: [Exception... "Creating an instance of prpl-jstest but this object implements prpl-js test'Creating an instance of prpl-jstest but this object implements prpl-js test' when calling method: [prplIProtocol::init]"  nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)"  location: "JS frame :: file:///Users/pcloke/mozilla/comm-central/obj-x86_64-apple-darwin13.3.0/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/components/imCore.js :: CoreService.prototype.getProtocolById :: line 338"  data: no]
Source File: file:///Users/pcloke/mozilla/comm-central/obj-x86_64-apple-darwin13.3.0/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/components/imCore.js
Line: 340
Fallout from the changes in bug 955420
Blocks: 955420
Summary: JS test throwing errors → JS Test protocol throwing errors due to normalizedName being incorrect
Attached patch Patch v1 (obsolete) — Splinter Review
This is the "dumb" fix, maybe there's something more insidious that needs to be fixed, however. Let me know.
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Attachment #8478757 - Flags: review?(aleth)
Comment on attachment 8478757 [details] [diff] [review]
Patch v1

Wrong patch file, this also contains your patch from bug 955574.
Attached patch Patch v1.1 (obsolete) — Splinter Review
Attachment #8478757 - Attachment is obsolete: true
Attachment #8478757 - Flags: review?(aleth)
Attachment #8478970 - Flags: review?(aleth)
Comment on attachment 8478970 [details] [diff] [review]
Patch v1.1

Review of attachment 8478970 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8478970 - Flags: review?(aleth) → review+
Keywords: checkin-needed
After discussion on IRC it seems to make more sense to use this alternative patch to change the normalization of the protocols to remove spaces as it used to do. (This is required so that it matches the component name, I believe, [1].)

[1] http://mxr.mozilla.org/comm-central/source/chat/protocols/jsTest/jsTestProtocol.manifest#3
Attachment #8478970 - Attachment is obsolete: true
Attachment #8478997 - Flags: review?(aleth)
Comment on attachment 8478997 [details] [diff] [review]
Alternative patch v1

Review of attachment 8478997 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for bringing up this alternative.
Attachment #8478997 - Flags: review?(aleth) → review+
https://hg.mozilla.org/comm-central/rev/a986d200c665
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.