1058360 - JS Test protocol throwing errors due to normalizedName being incorrect

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Patrick Cloke [:clokep]]

Timestamp: 8/25/14, 9:48:40 PM
Error: uncaught exception: Creating an instance of prpl-jstest but this object implements prpl-js test

Timestamp: 8/25/14, 9:48:40 PM
Error: Could not initialize protocol prpl-jstest: [Exception... "Creating an instance of prpl-jstest but this object implements prpl-js test'Creating an instance of prpl-jstest but this object implements prpl-js test' when calling method: [prplIProtocol::init]"  nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)"  location: "JS frame :: file:///Users/pcloke/mozilla/comm-central/obj-x86_64-apple-darwin13.3.0/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/components/imCore.js :: CoreService.prototype.getProtocolById :: line 338"  data: no]
Source File: file:///Users/pcloke/mozilla/comm-central/obj-x86_64-apple-darwin13.3.0/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/components/imCore.js
Line: 340

Comment 1

[Patrick Cloke [:clokep]]

Fallout from the changes in bug 955420

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Patch v1

This is the "dumb" fix, maybe there's something more insidious that needs to be fixed, however. Let me know.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8478757 [details] [diff] [review]
Patch v1

Wrong patch file, this also contains your patch from bug 955574.

Comment 4

[Patrick Cloke [:clokep]]

Attachment: Patch v1.1

Comment 5

[aleth [:aleth]]

Comment on attachment 8478970 [details] [diff] [review]
Patch v1.1

Review of attachment 8478970 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Patrick Cloke [:clokep]]

Attachment: Alternative patch v1

After discussion on IRC it seems to make more sense to use this alternative patch to change the normalization of the protocols to remove spaces as it used to do. (This is required so that it matches the component name, I believe, [1].)

[1] http://mxr.mozilla.org/comm-central/source/chat/protocols/jsTest/jsTestProtocol.manifest#3

Comment 7

[aleth [:aleth]]

Comment on attachment 8478997 [details] [diff] [review]
Alternative patch v1

Review of attachment 8478997 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for bringing up this alternative.

Comment 8

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/a986d200c665