Closed
Bug 1058360
Opened 7 years ago
Closed 7 years ago
JS Test protocol throwing errors due to normalizedName being incorrect
Categories
(Chat Core :: General, defect)
Chat Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: clokep, Assigned: clokep)
References
Details
Attachments
(1 file, 2 obsolete files)
1.40 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
Timestamp: 8/25/14, 9:48:40 PM Error: uncaught exception: Creating an instance of prpl-jstest but this object implements prpl-js test Timestamp: 8/25/14, 9:48:40 PM Error: Could not initialize protocol prpl-jstest: [Exception... "Creating an instance of prpl-jstest but this object implements prpl-js test'Creating an instance of prpl-jstest but this object implements prpl-js test' when calling method: [prplIProtocol::init]" nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)" location: "JS frame :: file:///Users/pcloke/mozilla/comm-central/obj-x86_64-apple-darwin13.3.0/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/components/imCore.js :: CoreService.prototype.getProtocolById :: line 338" data: no] Source File: file:///Users/pcloke/mozilla/comm-central/obj-x86_64-apple-darwin13.3.0/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/components/imCore.js Line: 340
Assignee | ||
Updated•7 years ago
|
Summary: JS test throwing errors → JS Test protocol throwing errors due to normalizedName being incorrect
Assignee | ||
Comment 2•7 years ago
|
||
This is the "dumb" fix, maybe there's something more insidious that needs to be fixed, however. Let me know.
Comment 3•7 years ago
|
||
Comment on attachment 8478757 [details] [diff] [review] Patch v1 Wrong patch file, this also contains your patch from bug 955574.
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8478757 -
Attachment is obsolete: true
Attachment #8478757 -
Flags: review?(aleth)
Attachment #8478970 -
Flags: review?(aleth)
Comment 5•7 years ago
|
||
Comment on attachment 8478970 [details] [diff] [review] Patch v1.1 Review of attachment 8478970 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8478970 -
Flags: review?(aleth) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•7 years ago
|
||
After discussion on IRC it seems to make more sense to use this alternative patch to change the normalization of the protocols to remove spaces as it used to do. (This is required so that it matches the component name, I believe, [1].) [1] http://mxr.mozilla.org/comm-central/source/chat/protocols/jsTest/jsTestProtocol.manifest#3
Attachment #8478970 -
Attachment is obsolete: true
Attachment #8478997 -
Flags: review?(aleth)
Comment 7•7 years ago
|
||
Comment on attachment 8478997 [details] [diff] [review] Alternative patch v1 Review of attachment 8478997 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for bringing up this alternative.
Attachment #8478997 -
Flags: review?(aleth) → review+
Assignee | ||
Comment 8•7 years ago
|
||
https://hg.mozilla.org/comm-central/rev/a986d200c665
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•