Closed Bug 1058399 Opened 5 years ago Closed 5 years ago

VideoData leak with mac fmp4

Categories

(Core :: Audio/Video, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

Recent try pushes show we're leaking VideoData on shutdown. I've seen this locally as well.

21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 AsyncTransactionTrackersHolder (72 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 100 CompositableClient (4000 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 CondVar (40 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 194 GfxTextureWasteTracker (776 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 144 Image (13824 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 194 MemoryTextureClient (26384 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 Mutex (32 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 PImageBridgeChild (760 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 RefCountedMonitor (80 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 2 RefCountedTask (32 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 144 SharedPlanarYCbCrImage (35712 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 144 VideoData (11520 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 WeakReference<MessageListener> (16 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 1 ipc::MessageChannel (536 bytes)
21:12:37     INFO -  TEST-INFO | leakcheck | leaked 3 nsTArray_base (24 bytes)
21:12:37  WARNING -  TEST-UNEXPECTED-FAIL | leakcheck | 93808 bytes leaked (AsyncTransactionTrackersHolder, CompositableClient, CondVar, GfxTextureWasteTracker, Image, ...)
Blocks: 1043696
In AppleVTDecoder::Flush() you call mReorderQueue.Clear(), but that won't delete the VideoData objects in the queue, you need to pop and delete them until the queue is empty. At least, that's my guess.
Looks like it. Thanks!
Assignee: nobody → giles
Attachment #8479358 - Flags: review?(cpearce)
Attachment #8479358 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/8ad9756bb025
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.