1058449 - Tapping on the settings button in contacts doesn't have any effect

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Marcela Oniga]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131028113308

Steps to reproduce:

1. Go to contacts and press to Settings





Actual results:

Contacts settings is not working, nothing happens after pressing it.


Expected results:

Contacts settings should be displayed with all the options.

Note: I used for testing OS version 2.1.0.0 prerelease, platform version 34.0a1, build identifier: 20140825040204 nightly build.

Comment 1

[Marcia Knous [:marcia]]

Marcela: I am not seeing this using:

Gaia   4d1d0ea5a82cddeeab497774cfa1703639e3c7d9
SourceStamp dc352a7bf234
BuildID 20140826040204
Version 34.0a1
Base image: v123

Can you please recheck with a later build?

Comment 2

[Johan Lorenzo [:jlorenzo]]

I saw that problem this morning with the same build as you Marcia. I saw it during the Right to Left bug bash and I thought it was related to that. But now I can't repro neither in RTL or in LTR.

Adding steps-wanted then.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Changing the name to make it more precise.

Comment 4

[Cody Roesch [:croesch]]

Hi Marcela,
   I was trying to work on this issue but even with the nightly build you provided, I'm unable to repro this bug. Can you provide a video of this issue?

I tried this on a Flame AND OpenC device and did the following

1. Flash the Flame device to build
2. Launch Contacts
3. Tap settings (Nothing happens)

Is there anything I'm missing here?

Thank you!

Comment 5

[Marcela Oniga]

I updated the device build  with:

Gaia   6e804a42ab90f4251c7fe8c68731dc1c6abd8006
SourceStamp 0753f7b93ab7
BuildID 20140827040203
Version 34.0a1

It seems that the issue is no longer reproducing on this version.

Comment 6

[Marcela Oniga]

Marking the bug as verified.

Comment 7

[Marcia Knous [:marcia]]

I am going to reopen this for further investigation as the issue is presenting itself again on one of my Flame devices.

Gaia   3a838afca295c9db32e1a3ec76d49fb7fe7fd2d2
SourceStamp 3be45b58fc47
BuildID 20140828040204
Version 34.0a1
base image: v123

I not able to reproduce it 100%, but it definitely is happening intermittently.

Comment 8

[Joshua Mitchell (Inactive)]

restoring steps-wanted tag to loop in QA-wanted team for support.

Comment 9

[Cody Roesch [:croesch]]

Ok I finally got this issue to happen a few times. It's definitely intermittent though. I can't get it to happen every time I reset and try to narrow down the steps. Once it happens though, you can't recover your functionality without a reboot/reset.

It happens most often when:
1. Opening a few apps along with Contacts. (camera,dialer,Sms)
2. Edge Gesturing between the apps
3. Then closing apps by bringing up card view and swiping up.
4. Reopen contacts and the Settings button has no function.

These steps are the closest I can get right now but I'll try to narrow them down even more. I've encountered the issue 3 times in an hour. Just wanted to post something to possibly lead to ideas from other people.

Environmental Variables:
Device: Flame Master
BuildID: 20140829061359
Gaia: 007f3c50cf69f044628a23c2376c6d88aa45f617
Gecko: d728b2f31c56
Version: 34.0a1 (Master) 
Firmware Version: v123

Comment 10

[Cody Roesch [:croesch]]

Video Link:
http://youtu.be/3Qjiq6NF6OI

Ok, I narrowed this down and can reliably repro this bug.

1. Open Contacts app.
2. Open Camera app and take a photo.
3. Close out both the apps in card view.
4. Reopen both contacts and camera apps and close them again.
5. Open Contacts and settings button is broken.

This bug repro's on: Flame 2.1

Actual Results: Settings button in Contacts stops having functionality.

Repro Rate: 5/5

Environmental Variables:
Device: Flame Master
BuildID: 20140829120602
Gaia: 007f3c50cf69f044628a23c2376c6d88aa45f617
Gecko: 11e4f1678eab
Version: 34.0a1 (Master) 
Firmware Version: v123

------------------------------------------------
------------------------------------------------

This bug does NOT repro on: Flame 2.0, Flame 1.4, OpenC 2.1

Actual Result: Settings button for Contacts stays functioning correctly.

Repro Rate: 0/4 attempts

Environmental Variables:
Device: Flame 2.0
BuildID: 20140827201151
Gaia: ee5cf3aff7e66ec5e899bdffa27ef51bfa40f0f0
Gecko: 218771782328
Version: 32.0 (2.0) 
Firmware Version: v123
-----------------------------------------------
Environmental Variables:
Device: Flame 1.4
BuildID: 20140827090228
Gaia: 05653cb12d324649687dad3eeb2ea373a2ad84d4
Gecko: baf01c5965ef
Version: 30.0 (1.4) 
Firmware Version: v123
-----------------------------------------------
Environmental Variables:
Device: Open_C Master
BuildID: 20140829120602
Gaia: 007f3c50cf69f044628a23c2376c6d88aa45f617
Gecko: 11e4f1678eab
Version: 34.0a1 (Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

Comment 11

[Joshua Mitchell (Inactive)]

Traige analysis - I'm on the fence about nomming this issue. It IS a regression but the current STR are really off the main-use path. That being said - it has obviously been encountered by several people randomly. I'm learning toward no-nom but just barely.

Comment 12

[Marcela Oniga]

I was able to reproduce the issue using Aurora 2.1:

Gaia   a47ecb6368c015dd72148acde26413fd90ba3136
SourceStamp 757931d0149e
BuildID 20140904000203
Version 34.0a2

Logs attached.

Steps to reproduce:
Perform some actions like, make a call, import contacts, browse some websites, and then open Contacts app. I was not able to open contacts settings anymore.

Comment 13

[Marcela Oniga]

Attachment: log.txt

Comment 14

[Jason Smith [:jsmith]]

(In reply to Joshua Mitchell [:Joshua_M] from comment #11)
> Traige analysis - I'm on the fence about nomming this issue. It IS a
> regression but the current STR are really off the main-use path. That being
> said - it has obviously been encountered by several people randomly. I'm
> learning toward no-nom but just barely.

Agree it's a tough one to evaluate. I think my main concern here is that this seems like a realistic dogfooding bug that users could hit during normal usage. It's also got an unpleasant recovery path (reboot the phone). My gut is leaning on the side of saying of putting this on nomination queue for being a bad dogfooding bug, but let's see what Bhavana thinks first before I do that.

Comment 15

[bhavana bajaj [:bajaj]]

(In reply to Jason Smith [:jsmith] from comment #14)
> (In reply to Joshua Mitchell [:Joshua_M] from comment #11)
> > Traige analysis - I'm on the fence about nomming this issue. It IS a
> > regression but the current STR are really off the main-use path. That being
> > said - it has obviously been encountered by several people randomly. I'm
> > learning toward no-nom but just barely.
> 
> Agree it's a tough one to evaluate. I think my main concern here is that
> this seems like a realistic dogfooding bug that users could hit during
> normal usage. It's also got an unpleasant recovery path (reboot the phone).
> My gut is leaning on the side of saying of putting this on nomination queue
> for being a bad dogfooding bug, but let's see what Bhavana thinks first
> before I do that.

I went through the use case myself and watched the video, although the STR might be complex its easy to hit during dogfooding the phone or day-day use, I recommend nominating this bug.

Comment 16

[Jason Smith [:jsmith]]

[Blocking Requested - why for this release]:

Based on the above comments, we think this is a bad dogfooding regression. The STR might be complex, but the reality is that someone will hit this during basic usage of the phone. The recovery path is ugly too - it requires a phone reboot. On that regard, I think we need to block on this.

Comment 17

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: let's plus it now per comment 16. Francisco will investigate on this.

Comment 18

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1040017 seems to be the cause for this bug

Mozilla-inbound Regression Window

Last working
Environmental Variables:
Device: Flame 2.1
BuildID: 20140821223018
Gaia: afcdd36f13e75adcdebe57d842a277fd587faf28
Gecko: c365e93b8e42
Version: 34.0a1 (2.1)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


First Broken
Environmental Variables:
Device: Flame 2.1
BuildID: 20140821224417
Gaia: afcdd36f13e75adcdebe57d842a277fd587faf28
Gecko: a9c2b0b7adac
Version: 34.0a1 (2.1)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Last working gaia / First broken gecko - Issue DOES occur
Gaia: afcdd36f13e75adcdebe57d842a277fd587faf28
Gecko: a9c2b0b7adac

First broken gaia / Last working gecko - Issue does NOT occur
Gaia: afcdd36f13e75adcdebe57d842a277fd587faf28
Gecko: c365e93b8e42

Gecko Pushlog:  http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c365e93b8e42&tochange=a9c2b0b7adac

Comment 19

[Joshua Mitchell (Inactive)]

Broken by Bug 1040017 ? Can you take a look Patrick?

Comment 20

[Jose Manuel Cantera]

The problem can be 100% reproduced on a flame device that has not any SDCARD

Comment 21

[Jose Manuel Cantera]

Attachment: 24053.html

Comment 22

[Francisco Jordano [:arcturus] [:francisco]]

Great work Jose, please merge once everything is green.

Comment 23

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8489386 [details]
24053.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Regression caused by last feature work
[User impact] if declined:
Huge, for users without sdcard on devices with internal memory, contacts settings will stop working and the application will be unusable.
[Testing completed]:
Smoke test passed, and added more unit tests to check the especific error.
[Risk to taking this patch] (and alternatives if risky):
Risk low, the change is simple, we forget about all kinds of storage (internal memory) and always ask just for sdcard. It's about 5 lines of code and we ad more test cases to cover everything.
[String changes made]:

Comment 24

[Jason Smith [:jsmith]]

I'm confused here. Why are we trying to fix this with a Gaia patch? The regression range points this to being a gecko regression in Nuwa, which means we should patching gecko here, not Gaia. Unless we think a Gaia workaround is a safer fix to include here.

Comment 25

[[:fabrice] Fabrice Desré]

(In reply to Jason Smith [:jsmith] from comment #24)
> I'm confused here. Why are we trying to fix this with a Gaia patch? The
> regression range points this to being a gecko regression in Nuwa, which
> means we should patching gecko here, not Gaia. Unless we think a Gaia
> workaround is a safer fix to include here.

The regression points to the nuwa change, but the bug is actually in gaia - it's broken by a gecko behavior change that it was not dealing with properly even though it's perfectly expectable. So I think the fix here is right.

Comment 26

[Jose Manuel Cantera]

landed in master: 

https://github.com/mozilla-b2g/gaia/commit/3604b50af0161694381f5ebe1f6fe053fda022fb

Comment 27

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/194ad18eb64b96371d7d3e6dc09f6651c2a3b57e

Comment 28

[Seth Miko [:SMiko]]

Verified fixed on Flame 2.2 (319mb/full flash) and Flame 2.1 (319mb/full flash)
Issue does NOT occur using any of the above STRs.

Actual result: Contacts settings are displayed with all the options.

Device: Flame 2.2
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0