1063959 - Can't open contact settings if there is no mapped internal SD Card

Status: RESOLVED DUPLICATE of bug 1058449

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Gaël Goinvic]

Attachment: The patch to fix the error shared/js/contacts/import/utilities/sdcard.js

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0
Build ID: 20140722064054

Steps to reproduce:

I'm using a ZTE Open C mapped to a KIS3 partitions layout. ( Using this mod http://www.modaco.com/topic/373261-devrom208-firefox-os-b2g-for-zte-open-c-kis-3/ )

Here are the layout differences :
Kis 3. ~900mb /system (p12), ~1.9gb /data (p13), no SD card partition
Open C. ~800mb /system (p12), ~1gb /data (p13), ~900mb SD card partition (p24)

In this case, pressing the "Settings" button of the Contacts app doesn't open the settings.


Actual results:


When opening the contacts application with the Kis 3 partitions, the webapp throws an error :
"TypeError: SdCard.deviceStorage is null" {file: "app://communications.gaiamobile.org/shared/js/contacts/import/utilities/sdcard.js" line: 69}]




Expected results:

The contacts settings should be shown with throwing an error.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Asking for QA wanted to confirm this.

Thanks!

Comment 2

[Gaël Goinvic]

I just noticed there is a typo in my Expected Results. 
"The contacts settings should be shown with throwing an error." should be "The contacts settings should be shown without throwing an error."

I'll try to find people who could confirm this bug.

Comment 3

[Dietrich Ayala (:dietrich)]

Hi Gaël! What is the a11y review request for?

Tony, can you have someone in QA with this device take a look to confirm?

Comment 4

[Gaël Goinvic]

Hi

The a11y-review was for someone to check after my patch.

Maybe this tag is not intended to be used like this ?

The bug is pretty obvious just by looking at the code. It only happens if there is not mapped internal SD Card, which is not the standard case for Zte Open C...

Comment 5

[Dietrich Ayala (:dietrich)]

Hey Gaël, the a11y review is for accessibility review. What you want is code review.

Francisco, who is the right person for code review here?

Gaël, something you should investigate now is how to write a unit test or integration test for this... before Francisco or another reviewer asks you for it ;)

Some docs:

https://developer.mozilla.org/en-US/Firefox_OS/Platform/Automated_testing/Gaia_unit_tests

Comment 6

[Gaël Goinvic]

Ok got it.

I'll work on a unit-test asap.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Hi folks,

I would suggest Sergi Mansilla as reviewer for sdcard work.

Comment 8

[Tony Chung [:tchung]]

(In reply to Dietrich Ayala (:dietrich) from comment #3)
> Hi Gaël! What is the a11y review request for?
> 
> Tony, can you have someone in QA with this device take a look to confirm?

sorry for the late response.  is QA still needed for help here?

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8485432 [details] [diff] [review]
The patch to fix the error shared/js/contacts/import/utilities/sdcard.js

Hei Sergi,

can you take a look to this code?

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Oh, just realised this bug was not confirmed with QA, Johan will you have some time to check this?

Comment 11

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 8485432 [details] [diff] [review]
The patch to fix the error shared/js/contacts/import/utilities/sdcard.js

Hi Gaël,

It looks like the functionality you are introducing is already there on latest master (https://github.com/mozilla-b2g/gaia/blob/master/shared/js/contacts/import/utilities/sdcard.js#L70). It was fixed in the following PR: https://github.com/mozilla-b2g/gaia/commit/e520aae2d2817b694eb4da1541aa8ddd4d826e29.

What codebase version are you patching against?

(Looks like this could be a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1058449)

Comment 12

[Gaël Goinvic]

Yes it looks like it's fixed in the latest codebase. I think that it was fixed at the same time the bug #1058449 was fixed.

I was patching against an old version (delivered in september there : http://www.modaco.com/topic/373261-devrom511-caf-firefox-os-b2g-for-zte-open-c-kis-3/)

It looks like i need to do an upgrade of the current version then :)

This ticket can be closed !

Comment 13

[Johan Lorenzo [:jlorenzo]]

Clearing the NI per comment 12.