1058526 - Poor grammar in MMS error message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Zac C (:zac)]

Attachment: index.png

Bug 1057973 has exposed some poor grammar in an error message.

The language does not make it clear that the user should follow the link.

This message should be revised to be clearer to the user.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

This message was created from carrier-side as the message body of the MMS notification.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Sorry, after checking the screenshot, I just realized it's the MMS notification displayed in the SMS App with the locale in:
https://github.com/mozilla-b2g/gaia/blob/aa72df680c56bad1507ca0ee2d640d300fe91a1d/apps/sms/locales/sms.en-US.properties#L224

Comment 3

[Julien Wajsberg [:julienw]]

Hey Jenny, what do you think of this feedback?

Comment 4

[Jenny Lee]

Hi Matej, could you take a look at the string issue described here? Thanks!

Comment 5

[Matej Novak [:matej]]

(In reply to Jenny Lee from comment #4)
> Hi Matej, could you take a look at the string issue described here? Thanks!

I'm not sure I totally understand. It seems pretty clear to me that you're supposed to click on "Download" as a next step.

Here's one thought about how to clarify it even more, though:

"You can use the link below to download this attachment until Thursday, Aug. 28."

One other thing: "Aug." needs a period if we're using the abbreviation.

Comment 6

[Julien Wajsberg [:julienw]]

NI stas about the "Aug." issue since we're using l10n stuff for this.

Comment 7

[Staś Małolepszy :stas]

I think we should file a separate bug to fix the month (and possibly days?) abbreviations.  It should be as simple as changing the following en-US values: 

https://github.com/mozilla-b2g/gaia/blob/d69f170bf90d496c5f26b0f5c0a000922a323fbd/shared/locales/date/date.en-US.properties#L47-L58

Since it's not a semantic change, the string identifiers should stay the same.

Comment 8

[Julien Wajsberg [:julienw]]

Filed bug 1083300 for this last issue.

Comment 9

[Julien Wajsberg [:julienw]]

Matej, how about something like: "You received a multimedia message, you can use the link below to download its content until Thursday, Aug. 28." ?

I try to avoid using the word "attachment" because actually a MMS can have a subject and no attachment (quite common), or even just text (quite uncommon).

Comment 10

[Matej Novak [:matej]]

(In reply to Julien Wajsberg [:julienw] from comment #9)
> Matej, how about something like: "You received a multimedia message, you can
> use the link below to download its content until Thursday, Aug. 28." ?

Looks good, but it needs to be two sentences:

You received a multimedia message. You can use the link below to download its content until Thursday, Aug. 28.

Comment 11

[Julien Wajsberg [:julienw]]

Thanks Matej.

I'm making this a mentored bug. We need to change the value for not-downloaded-attachment in the locale properties file in sms.en_US.properties.

Because we change the value we also needs to change the key, and as a result we need to change the code that uses it in thread_ui.js and the unit test in thread_ui_test.js.

You can test the code in Firefox by following the steps in [1], and opening the thread for "Tom O'Hare" that has some "not-downloaded" MMS.

[1] https://github.com/julienw/gaia/blob/1082618-sms-readme/apps/sms/README.md

Comment 12

[kumar rishav (:rishav_)]

Hi Julien
What is the final decision on the string L10n value ? I am taking this bug.
Thanks

Comment 13

[kumar rishav (:rishav_)]

What should be the string (L10n  value) here?

Comment 14

[Julien Wajsberg [:julienw]]

What comment 10 said :)

Thanks!

Comment 15

[Julien Wajsberg [:julienw]]

Assigning this to Vishnu, because I know you're busy during this month Rishav :)

Comment 16

[kumar rishav (:rishav_)]

yeah..sure NP :)

Comment 17

[Vishnu Teja [:ythej]]

Attachment: 1058526.patch

Comment 18

[Vishnu Teja [:ythej]]

Attachment: Pull Request for fix

Comment 19

[Julien Wajsberg [:julienw]]

Comment on attachment 8513465 [details] [review]
Pull Request for fix

Looks good!

Please change your commit log in the form:

Bug 1058526 - Poor grammar in MMS error message r=julien

(first part is the title of the bug, second part is the reviewer).
You can change this using the command "git commit --amend" on your branch. Then you can push to your remote branch which will update the pull request (using "git push -f <your_remote_name> HEAD").

Then at last you can add "checkin-needed" in the "keywords" part on the bug (it's located at the top of the screen).

Thanks a lot for your help !

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/5964f1339f37e7595aff7de7512b8529bc640b76