Poor grammar in MMS error message

RESOLVED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::SMS
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: zac, Assigned: ythej, Mentored)

Tracking

unspecified
2.1 S8 (7Nov)
x86_64
Linux

Firefox Tracking Flags

(b2g-v2.2 fixed)

Details

(Whiteboard: [lang=js][sms-papercuts][good first bug])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8478943 [details]
index.png

Bug 1057973 has exposed some poor grammar in an error message.

The language does not make it clear that the user should follow the link.

This message should be revised to be clearer to the user.
This message was created from carrier-side as the message body of the MMS notification.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
Sorry, after checking the screenshot, I just realized it's the MMS notification displayed in the SMS App with the locale in:
https://github.com/mozilla-b2g/gaia/blob/aa72df680c56bad1507ca0ee2d640d300fe91a1d/apps/sms/locales/sms.en-US.properties#L224
Status: RESOLVED → REOPENED
Component: RIL → Gaia::SMS
Resolution: INVALID → ---
Hey Jenny, what do you think of this feedback?
Flags: needinfo?(jelee)

Comment 4

3 years ago
Hi Matej, could you take a look at the string issue described here? Thanks!
Flags: needinfo?(jelee) → needinfo?(Mnovak)

Comment 5

3 years ago
(In reply to Jenny Lee from comment #4)
> Hi Matej, could you take a look at the string issue described here? Thanks!

I'm not sure I totally understand. It seems pretty clear to me that you're supposed to click on "Download" as a next step.

Here's one thought about how to clarify it even more, though:

"You can use the link below to download this attachment until Thursday, Aug. 28."

One other thing: "Aug." needs a period if we're using the abbreviation.
Flags: needinfo?(Mnovak)
NI stas about the "Aug." issue since we're using l10n stuff for this.
Flags: needinfo?(stas)
I think we should file a separate bug to fix the month (and possibly days?) abbreviations.  It should be as simple as changing the following en-US values: 

https://github.com/mozilla-b2g/gaia/blob/d69f170bf90d496c5f26b0f5c0a000922a323fbd/shared/locales/date/date.en-US.properties#L47-L58

Since it's not a semantic change, the string identifiers should stay the same.
Flags: needinfo?(stas)
Filed bug 1083300 for this last issue.
Matej, how about something like: "You received a multimedia message, you can use the link below to download its content until Thursday, Aug. 28." ?

I try to avoid using the word "attachment" because actually a MMS can have a subject and no attachment (quite common), or even just text (quite uncommon).
Flags: needinfo?(Mnovak)
(In reply to Julien Wajsberg [:julienw] from comment #9)
> Matej, how about something like: "You received a multimedia message, you can
> use the link below to download its content until Thursday, Aug. 28." ?

Looks good, but it needs to be two sentences:

You received a multimedia message. You can use the link below to download its content until Thursday, Aug. 28.
Flags: needinfo?(Mnovak)
Thanks Matej.

I'm making this a mentored bug. We need to change the value for not-downloaded-attachment in the locale properties file in sms.en_US.properties.

Because we change the value we also needs to change the key, and as a result we need to change the code that uses it in thread_ui.js and the unit test in thread_ui_test.js.

You can test the code in Firefox by following the steps in [1], and opening the thread for "Tom O'Hare" that has some "not-downloaded" MMS.

[1] https://github.com/julienw/gaia/blob/1082618-sms-readme/apps/sms/README.md
Mentor: felash@gmail.com
Whiteboard: [lang=js][sms-papercuts][good first bug]
Hi Julien
What is the final decision on the string L10n value ? I am taking this bug.
Thanks
Assignee: nobody → rishav006
What should be the string (L10n  value) here?
Flags: needinfo?(felash)
What comment 10 said :)

Thanks!
Flags: needinfo?(felash)
Assigning this to Vishnu, because I know you're busy during this month Rishav :)
Assignee: rishav006 → vish.thej
yeah..sure NP :)
(Assignee)

Comment 17

3 years ago
Created attachment 8512817 [details] [diff] [review]
1058526.patch
(Assignee)

Updated

3 years ago
Attachment #8512817 - Flags: review?(felash)
(Assignee)

Comment 18

3 years ago
Created attachment 8513465 [details] [review]
Pull Request for fix
Attachment #8513465 - Flags: review?(felash)
Comment on attachment 8513465 [details] [review]
Pull Request for fix

Looks good!

Please change your commit log in the form:

Bug 1058526 - Poor grammar in MMS error message r=julien

(first part is the title of the bug, second part is the reviewer).
You can change this using the command "git commit --amend" on your branch. Then you can push to your remote branch which will update the pull request (using "git push -f <your_remote_name> HEAD").

Then at last you can add "checkin-needed" in the "keywords" part on the bug (it's located at the top of the screen).

Thanks a lot for your help !
Attachment #8513465 - Flags: review?(felash) → review+
Attachment #8512817 - Attachment is obsolete: true
Attachment #8512817 - Flags: review?(felash)
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/5964f1339f37e7595aff7de7512b8529bc640b76
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
status-b2g-v2.2: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in before you can comment on or make changes to this bug.