1058727 - [RTL] Music Notification buttons Next/Prev are reversed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Adnane Belmadiaf]

Attachment: Capture du 2014-08-26 18:21:49.png

User Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/36.0.1985.125 Chrome/36.0.1985.125 Safari/537.36

Steps to reproduce:

- Play a song
- Pull the notification menu


Actual results:

Music Notification buttons order :
Prev - Play/Pause - Next


Expected results:

Music Notification buttons order :
Next - Play/Pause - Prev

Comment 1

[Hubert Figuiere [:hub]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26454

Etienne: this is a CSS change in the system notification tray for the media playback control to fix in RTL.

Thank you kindly.

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8528520 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26454

Redirecting to Guillaume!
(but looking good)

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8528520 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26454

Looks good to me. Thanks!

Comment 4

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/58f8e8dc6a587378374cadccf78bd14ad38cf594

Comment 5

[Elie]

This issue dose not exist on Flame 2.2：
Gaia-Rev        7c5b27cad370db377b18a742d3f3fdb0070e899f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/748b20315f75
Build-ID        20150114002502
Version         37.0a2
Reproduce rate： 0/5

Comment 6

[Elie]

Attachment: 2015-01-15-16-05-50.png

Verified successfully screenshoot

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

thanks for the verification! Please take out the verifyme keyword once you've actually verified the fix. Thanks!

Comment 8

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15576/

Comment 9

[Shine(Leave from Mozilla)]

Attachment: Flame_master_verify1.png

This problem is verified as "pass" on latest build of Flame master and N5 master by the STR in comment 0.
Actual result: The order of buttons on ongoing music process control bar in notification from right to left is: Next - Play/Pause - Prev.
See attachment: Flame_master_verify1.png
Rate: 0/5

Device information:
Flame master (Pass)
Build ID               20150715160204
Gaia Revision          b9968cdc4a1dee49848fed6159a59c378cea062d
Gaia Date              2015-07-15 12:13:34
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/49683d4e9ebd
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150715.192231
Firmware Date          Wed Jul 15 19:22:42 EDT 2015
Bootloader             L1TC000118D0

N5 master (Pass)
Build ID               20150715160204
Gaia Revision          b9968cdc4a1dee49848fed6159a59c378cea062d
Gaia Date              2015-07-15 12:13:34
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/49683d4e9ebd
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150715.191550
Firmware Date          Wed Jul 15 19:16:07 EDT 2015
Bootloader             HHZ12f