[RTL] Music Notification buttons Next/Prev are reversed

VERIFIED FIXED in 2.2 S1 (5dec)

Status

defect
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: adnane002, Assigned: hub)

Tracking

unspecified
2.2 S1 (5dec)
Dependency tree / graph
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(feature-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)

Details

(Whiteboard: [2.1-Arabic-RTL-bug-bash] [ft:media])

Attachments

(4 attachments)

Reporter

Description

5 years ago
User Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/36.0.1985.125 Chrome/36.0.1985.125 Safari/537.36

Steps to reproduce:

- Play a song
- Pull the notification menu


Actual results:

Music Notification buttons order :
Prev - Play/Pause - Next


Expected results:

Music Notification buttons order :
Next - Play/Pause - Prev
Reporter

Updated

5 years ago
Whiteboard: [2.1-Arabic-RTL-bug-bash]
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

5 years ago
Blocks: music-rtl
No longer blocks: gaia-rtl
Assignee

Updated

5 years ago
Assignee: nobody → hub
Status: NEW → ASSIGNED
Assignee

Updated

5 years ago
Target Milestone: --- → 2.2 S1 (5dec)

Updated

5 years ago
feature-b2g: --- → 2.2+

Updated

5 years ago
Whiteboard: [2.1-Arabic-RTL-bug-bash] → [2.1-Arabic-RTL-bug-bash] [ft:media]
Assignee

Comment 1

5 years ago
Etienne: this is a CSS change in the system notification tray for the media playback control to fix in RTL.

Thank you kindly.
Attachment #8528520 - Flags: review?(etienne)
Comment on attachment 8528520 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26454

Redirecting to Guillaume!
(but looking good)
Attachment #8528520 - Flags: review?(etienne) → review?(gmarty)
Comment on attachment 8528520 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26454

Looks good to me. Thanks!
Attachment #8528520 - Flags: review?(gmarty) → review+
Assignee

Comment 4

5 years ago
Merged
https://github.com/mozilla-b2g/gaia/commit/58f8e8dc6a587378374cadccf78bd14ad38cf594
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Keywords: verifyme

Comment 5

5 years ago
This issue dose not exist on Flame 2.2:
Gaia-Rev        7c5b27cad370db377b18a742d3f3fdb0070e899f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/748b20315f75
Build-ID        20150114002502
Version         37.0a2
Reproduce rate: 0/5
Status: RESOLVED → VERIFIED

Comment 6

5 years ago
Verified successfully screenshoot
thanks for the verification! Please take out the verifyme keyword once you've actually verified the fix. Thanks!
Keywords: verifyme

Updated

4 years ago
Flags: in-moztrap-
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15576/
Flags: in-moztrap- → in-moztrap+

Updated

4 years ago
Blocks: system-rtl
No longer blocks: music-rtl
This problem is verified as "pass" on latest build of Flame master and N5 master by the STR in comment 0.
Actual result: The order of buttons on ongoing music process control bar in notification from right to left is: Next - Play/Pause - Prev.
See attachment: Flame_master_verify1.png
Rate: 0/5

Device information:
Flame master (Pass)
Build ID               20150715160204
Gaia Revision          b9968cdc4a1dee49848fed6159a59c378cea062d
Gaia Date              2015-07-15 12:13:34
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/49683d4e9ebd
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150715.192231
Firmware Date          Wed Jul 15 19:22:42 EDT 2015
Bootloader             L1TC000118D0

N5 master (Pass)
Build ID               20150715160204
Gaia Revision          b9968cdc4a1dee49848fed6159a59c378cea062d
Gaia Date              2015-07-15 12:13:34
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/49683d4e9ebd
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150715.191550
Firmware Date          Wed Jul 15 19:16:07 EDT 2015
Bootloader             HHZ12f
QA Whiteboard: [MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.