Closed
Bug 1058742
Opened 11 years ago
Closed 10 years ago
[RTL] Low Battery warning lacks RTL support
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(ux-b2g:2.2, b2g-v2.2 verified)
People
(Reporter: nefzaoui, Unassigned)
References
Details
(Whiteboard: [2.1-Arabic-RTL-bug-bash][systemsfe])
Attachments
(2 files)
No description provided.
Updated•11 years ago
|
Comment 1•11 years ago
|
||
Still reproducing on 2.2.
Updated•11 years ago
|
ux-b2g: --- → 2.2
Updated•11 years ago
|
feature-b2g: --- → 2.2+
Whiteboard: [2.1-Arabic-RTL-bug-bash] → [2.1-Arabic-RTL-bug-bash][systemsfe]
Updated•10 years ago
|
feature-b2g: 2.2+ → ---
Comment 2•10 years ago
|
||
| Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8547188 [details] [review]
[PullReq] anefzaoui:bug-1058742 to mozilla-b2g:master
Please review
Thanks!
Attachment #8547188 -
Flags: review?(alive)
Comment 4•10 years ago
|
||
Comment on attachment 8547188 [details] [review]
[PullReq] anefzaoui:bug-1058742 to mozilla-b2g:master
Forwarding review (I am not sure if we shall do float: right for all icons?)
Attachment #8547188 -
Flags: review?(alive) → review?(mhenretty)
Comment 5•10 years ago
|
||
Comment on attachment 8547188 [details] [review]
[PullReq] anefzaoui:bug-1058742 to mozilla-b2g:master
WFM. This change only applies to the low battery toaster icon, so I don't think we need to worry about other icons as part of this change.
Attachment #8547188 -
Flags: review?(mhenretty) → review+
Updated•10 years ago
|
Comment 7•10 years ago
|
||
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.
Updated•10 years ago
|
Attachment #8547188 -
Flags: review+
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/3f4863c28b49837ed470b7ce1acee4b6ec3ae787
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 10•10 years ago
|
||
This issue verified successfully on flame 2.2
Gaia-Rev f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5d7497ce4cc7
Build-ID 20150120002507
Version 37.0a2
Device-Name flame
FW-Release 4.4.2
Refer to video VIDEO0270.mp4
Status: RESOLVED → VERIFIED
status-b2g-v2.2:
--- → verified
Comment 11•10 years ago
|
||
Comment 12•10 years ago
|
||
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15664/
Flags: in-moztrap+
Updated•10 years ago
|
QA Whiteboard: [rtl-impact]
You need to log in
before you can comment on or make changes to this bug.
Description
•