Closed Bug 1058752 Opened 10 years ago Closed 10 years ago

[RTL] Camera button alignment is off

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 verified)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
b2g-v2.2 --- verified

People

(Reporter: marcia, Unassigned)

References

Details

(Whiteboard: [2.1-Arabic-RTL-bug-bash])

Attachments

(3 files, 1 obsolete file)

2014-08-26-10-37-38.png
779.79 KB, image/png
Details
Correct display of buttons in non RTL
808.49 KB, image/png
Details
patch for Gaia/master
46 bytes, text/x-github-pull-request
wilsonpage
: review+
Details | Review
Attached image 2014-08-26-10-37-38.png — 
Flame device, running:

Gaia   e424c85eda87a40c0fa64d6a779c3fa368bf770b
SourceStamp daa84204a11a
BuildID 20140825040204
Version 34.0a1
base image: V123

Steps to Reproduce:
1. Open the camera app
2. Observe the attached screenshot
Attached file patch for Gaia/master (obsolete) — 

        Attachment #8483289 -
        Flags: review?(wilsonpage)

    
    

    
  
Comment on attachment 8483289 [details] [review]
patch for Gaia/master

It looks like the patch just better positions the switch in it's altered location. I don't think it makes sense for the switch to move from the left to the right side of the screen for rtl users.

Can we override this default behaviour for the camera controls? Otherwise I imagine we'll continue to discover scenarios that UX/Visual didn't plan for.

        Attachment #8483289 -
        Flags: review?(wilsonpage)

    
    

    
  
I agree with you.

Hey Stephany, what do you think?
Flags: needinfo?(swilkes)

    
    

    
  
I agree with Wilson and Pavel. :) Thanks guys!
Flags: needinfo?(swilkes)

    
    

    
  
I will mark it as Invalid

Thanks all :)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID

    
    

    
  
(In reply to Pavel Ivanov [:ivanovpavel] from comment #6)
> I will mark it as Invalid
> 
> Thanks all :)

Do we have to override the default rtl flexbox behaviour to prevent the app from getting into this state?
Flags: needinfo?(pivanov)

    
    

    
  
Right!
Status: RESOLVED → REOPENED
Flags: needinfo?(pivanov)
Resolution: INVALID → ---

        Attachment #8483289 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached file
          
        patch for Gaia/master
        — 
      

    


  

        Attachment #8485907 -
        Flags: review?(wilsonpage)

        Attachment #8485907 -
        Flags: review?(wilsonpage) → review+

    
    

    
  
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/712033041dfbcfab83b3823f649b0ed5f9abf408
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED

    
  
Blocks: camera-rtl
No longer blocks: gaia-rtl

    
    

    
  
Verified the issue is fixed on 2.2 Flame

Camera button alignment is on

Flame 2.2

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141204040202
Gaia: 984e6d79aa799d2695f9ca132dfdc1665a56c019
Gecko: a9fc46355661
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]

          status-b2g-v2.2:
          --- → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)

    
  
Flags: in-moztrap-

    
    

    
  
Test case has been added in moztrap:

https://moztrap.mozilla.org/manage/case/15920/
Flags: in-moztrap- → in-moztrap+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: