Closed
Bug 1058798
Opened 11 years ago
Closed 11 years ago
[CSS/SVG Filters][Refactoring] Fix indentation in nsCSSFilterInstance.h and nsSVGFilterInstance.h
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: mvujovic, Assigned: mvujovic)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.56 KB,
patch
|
mstange
:
review+
mvujovic
:
checkin+
|
Details | Diff | Splinter Review |
Some of the member variables aren't indented consistently in these .h files. Doesn't look pretty.
| Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8483630 -
Flags: review?(mstange)
Comment 2•11 years ago
|
||
Comment on attachment 8483630 [details] [diff] [review]
Patch
Can I get another patch that does the reverse change for everything? :)
I don't want to mess up your queue, let's land this, but I really don't like this indentation style.
Attachment #8483630 -
Flags: review?(mstange) → review+
| Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Markus Stange [:mstange] from comment #2)
> Comment on attachment 8483630 [details] [diff] [review]
> Patch
>
> Can I get another patch that does the reverse change for everything? :)
> I don't want to mess up your queue, let's land this, but I really don't like
> this indentation style.
Absolutely :)
This new patch also updates the indentation in nsFilterInstance.h.
No worries about the queue. I can land this patch.
Attachment #8483630 -
Attachment is obsolete: true
Comment 4•11 years ago
|
||
Comment on attachment 8483732 [details] [diff] [review]
Patch [v2]
Much better! :)
Attachment #8483732 -
Flags: review+
| Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8483732 [details] [diff] [review]
Patch [v2]
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b163e68db8f
https://tbpl.mozilla.org/?tree=Try&rev=b00d1e2c72db
Attachment #8483732 -
Flags: checkin+
Assignee: nobody → mvujovic
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•