1058852 - Remove unused resources

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

"lint --check UnusedResources android_eclipse" reports a number of unused drawables. Several of these are in fact referenced from JS via drawable:// URIs, but some are not in the tree at all. We should remove them.

Comment 1

[Richard Newman [:rnewman]]

Got a list?

Also yaaaaaaayyyyyy.

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Remove unused drawables

Approach used:

1) MXR for filename without extension.
2) If no results, MXR for prefixes of that name (e.g., "suggestedsites_fxaddons" shows no results, but "suggestedsites_" shows that these names are dynamically referenced).
3) If no results, delete it.

This ends up saving ~40KB in the APK.

Comment 3

[Brian Nicholson (:bnicholson)]

Candidates here: https://pastebin.mozilla.org/6166359

I looked only for drawables for this patch. There are probably other XML resources that could be purged.

Comment 4

[Brian Nicholson (:bnicholson)]

Attachment: Remove unused layouts

Only gives us another 4KB or so, but still good to remove cruft.

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8479364 [details] [diff] [review]
Remove unused layouts

Review of attachment 8479364 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if the FxA status activity still works after this!

::: mobile/android/base/resources/layout/fxaccount_status.xml
@@ -1,5 @@
> -<?xml version="1.0" encoding="utf-8"?>
> -<!--
> -   This Source Code Form is subject to the terms of the Mozilla Public
> -   - License, v. 2.0. If a copy of the MPL was not distributed with this
> -   - file, You can obtain one at http://mozilla.org/MPL/2.0/.

Err:

wc -l mobile/android/base/resources/layout/fxaccount_status.xml
     118

I'm puzzled why this file is empty in your tree.

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8479334 [details] [diff] [review]
Remove unused drawables

Review of attachment 8479334 [details] [diff] [review]:
-----------------------------------------------------------------

fxaccount* ones need to be upstreamed when you land this. I can take care of that.

\o/

Comment 7

[Brian Nicholson (:bnicholson)]

(In reply to Richard Newman [:rnewman] from comment #5)
> Err:
> 
> wc -l mobile/android/base/resources/layout/fxaccount_status.xml
>      118
> 
> I'm puzzled why this file is empty in your tree.

It's not -- check the raw diff :) Looks like a bug with splinter review.

Comment 8

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/30684d07599d
https://hg.mozilla.org/integration/fx-team/rev/512b16337fa9

Comment 9

[Richard Newman [:rnewman]]

ni me for upstreaming.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed both out in https://hg.mozilla.org/integration/fx-team/rev/aca5bff5dce5 for failing pretty much across the board on Android 2.3: https://tbpl.mozilla.org/?tree=Fx-Team&rev=512b16337fa9

Comment 11

[Bob Clary [:bc] (inactive)]

This also broke Autophone's webappstartup test.

Comment 12

[Richard Newman [:rnewman]]

    Bitmap getScrollbarImage() {
        return getDrawable("scrollbar");
    }

Guess scrollbar.png was needed…


And this might indicate some kind of incremental build issue:

16:52:42     INFO -  08-26 16:46:24.515 W/ResourceType(  418): No package identifier when getting value for resource number 0x00000000

Comment 13

[Richard Newman [:rnewman]]

https://tbpl.mozilla.org/?tree=Try&rev=f372b51fa75d

Comment 14

[Richard Newman [:rnewman]]

That's a try push with scrollbar.png restored.

Comment 15

[Richard Newman [:rnewman]]

Try looks green to me, so I'll reland.

Comment 16

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/6afb431e77e0
https://hg.mozilla.org/integration/fx-team/rev/26170fba2c2b

Comment 17

[Richard Newman [:rnewman]]

https://github.com/mozilla-services/android-sync/commit/fffcca3f14368511569c4466cb7ae09866465fb8

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6afb431e77e0
https://hg.mozilla.org/mozilla-central/rev/26170fba2c2b