1058902 - Implement new tablet toolbar editing mode

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

And maybe the animations, if applicable.

Yuan, do we have mocks for what the toolbar should look like after it is pressed (e.g. currently, we hide the toolbar icons and add a close-editing-mode button)? Do we expect to have animations between these states?

Note that this is probably not necessary for new-tablet-v1.

Comment 1

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Thanks for creating the bug, Michael! 
I will work on the design and animations for this. I think we've initially agreed that tablet editing mode/search screen should feel lightweight. Since the tabs are visible on top on tablet, it makes more sense to maintain the state and only change the state inside of the URL bar. 

So I am leaning towards Firefox desktop drop-down UI for now. But it might have slight changes while I design for it :) 

I will keep you posted!

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Yuan, I will probably have time to get to this within the next week or two - do you have any specs?

Note to self: re-enable the options menu on new tablet only (from bug 956858) and de-couple editing mode and those interactions.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #2)
> Note to self: re-enable the options menu on new tablet only

Or maybe all devices because our "will never use the menu in editing mode" assumptions are all gone.

Comment 4

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Attachment: Tablet Search_Portrait_09212014

Please see attached link for the draft idea I put together for edit mode: http://delivery.yuuuan.com/gb3fcujq

Currently portrait mode only. But I can see this fit into a landscape mode pretty well.

Let's discuss these on Monday's tablet checkin!

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We'll be implementing this version of editing mode in at least v2 - see bug 1085596 for v1.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.