1085596 - [meta] Implement simplified (v1) new tablet editing mode

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Because we don't have enough time, we won't implement the full editing mode (bug 1058902) for v1. Instead, we'll implement a simplified version that is essentially 

Overview of the required changes (from the 10/13 new tablet meeting), potentially broken up into blocking bugs:
  * Back button behavior
  * Don't break if user does something while editing
  * Save/restore edited text when switching tabs
  * Show browser search when typing
  * Fix the alignment of editing mode (bug 1079182)

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #0)
>   * Show browser search when typing

My mistake: this already happens.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #0)
>   * Don't break if user does something while editing

bug 1086981.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #0)
>   * Save/restore edited text when switching tabs

bug 1086983

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Part 3: Cancel editing mode when hitting toolbar buttons

This works for the reload button too, but not the tabs button - that one is complicated because we can choose to leave editing mode open until a state change occurs (e.g. tab added/selected).

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8513115 [details] [diff] [review]
Part 3: Cancel editing mode when hitting toolbar buttons

Wrong bug.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Closing as dependent bugs are closed.