1058948 - Disable History & Location APIs in prerendering

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Roshan Vidyashankar [:rvid]]

Attachment: 1058948.patch

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 8483822 [details] [diff] [review]
1058948.patch

   [Throws]
   void pushState(any data, DOMString title, optional DOMString? url = null);
   [Throws]
   void replaceState(any data, DOMString title, optional DOMString? url = null);

Don't we want to flag these too? They directly mess with the history for the object in observable ways. r- until we figure that out.

Comment 3

[(no longer active)]

(In reply to Johnny Stenback  (:jst, [e-mail]) from comment #2)
> Comment on attachment 8483822 [details] [diff] [review]
> 1058948.patch
> 
>    [Throws]
>    void pushState(any data, DOMString title, optional DOMString? url = null);
>    [Throws]
>    void replaceState(any data, DOMString title, optional DOMString? url =
> null);
> 
> Don't we want to flag these too? They directly mess with the history for the
> object in observable ways. r- until we figure that out.

No, I don't think we want to do that.  The methods blacklisted here actually end up doing navigations, but pushState/replaceState don't.  Also bug 1045759 is filed for blacklisting other types of navigations.

Comment 4

[(no longer active)]

Comment on attachment 8483822 [details] [diff] [review]
1058948.patch

Requesting review again.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c556f8cd6f3a