1059061 - [Touch Caret] Disable touch caret on B2G 2.1

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Currently, touch caret is enabled on master branch, but I was told that touch caret should be disabled on B2G 2.1 release before 9/2.

Comment 1

[howie [:howie]]

Yes, please make sure touch caret is off in 2.1 branch. This needs to be done before 2.1 FL 9/1. Thanks.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Disable touch caret on B2G 2.1 release.

Try result:
https://tbpl.mozilla.org/?tree=Try&rev=40604ad760b0

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

It seems awkward to me that we have to disable touch caret on master and then enable it after 2.1 branch is created. Is there any flag to request this patch be landed on 2.1 branch directly? Should I set blocking-b2g:2.1?

Comment 4

[howie [:howie]]

Touch caret is not a 2.1 feature so it should not be on in 2.1 branch. There is flag to request uplift to 2.1 branch but requires additional approval; You can see flag approval-mozilla-version# when upload the patch. Blocking-b2g flag is for blocker not for this case. Clearer definition of blocker, FYI https://wiki.mozilla.org/B2G/Triage#Issues_that_Should_Block

Comment 5

[Peter Chang[:pchang]]

(In reply to howie [:howie] from comment #4)
> Touch caret is not a 2.1 feature so it should not be on in 2.1 branch. There
> is flag to request uplift to 2.1 branch but requires additional approval;
> You can see flag approval-mozilla-version# when upload the patch.
> Blocking-b2g flag is for blocker not for this case. Clearer definition of
> blocker, FYI https://wiki.mozilla.org/B2G/Triage#Issues_that_Should_Block

If we turn off on master now and turn on after 2.1 branch, we will have effort to check try server to make sure no regression and spend time to analyze the fail items which may or may not related to touchCaret.

After discussed with howie, we agree to land this 'disable touchcaret' patch on 2.1 branch after FL stage.

Comment 6

[(no longer active)]

Comment on attachment 8479645 [details] [diff] [review]
Disable touch caret on B2G 2.1 release.

r=me.  I have no preferences as to whether you want to land this on trunk first and then re-enable on trunk when we branch 2.1 or just wait and land it on the branch when we do branch, although I prefer to not get this disabled on trunk, so the second option sounds better.

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 8479645 [details] [diff] [review]
Disable touch caret on B2G 2.1 release.

Please set the status 2.1 as disabled once this lands on aurora.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6523b22295fb

I'd argue that as-filed, this bug is "fixed" on v2.1, but wontfix for v2.2. Bug 1016184 could probably be set to disabled for v2.1, though. :)