[Browser]Clear browsing and Clear cookies and stored data dialogs font is small

RESOLVED WONTFIX

Status

--
major
RESOLVED WONTFIX
4 years ago
9 months ago

People

(Reporter: vsireesha246, Unassigned)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:-, b2g-v2.0 affected, b2g-v2.0M affected)

Details

(Whiteboard: [LibGLA,TD91919,WW, B])

Attachments

(5 attachments)

(Reporter)

Description

4 years ago
STR:

1.Open Browser
2.Settings->click on Clear browsing or Clear cookies and stored data dialogs font is small buttons
3.The Font is small compared to other dialogs like:Gallery,video,etc
(Reporter)

Updated

4 years ago
Whiteboard: [LibGLA,TD91919,QE1, A]
(Reporter)

Comment 1

4 years ago
Hi Yliao,

The dialogs used in Bowser app is different from other apps.
We can increase the Font size for Browser app as well.
Please let me know your feedback about this issue in V2.0.

Thanks..
Sireesha
Flags: needinfo?(yliao)
(Reporter)

Updated

4 years ago
Whiteboard: [LibGLA,TD91919,QE1, A] → [LibGLA,TD91919,WW, B]
Created attachment 8492874 [details]
browser.png
Created attachment 8492878 [details]
gallery.png

Please see the attachments.

I'm not sure if this is an issue or by design. Wayne do you know about this?
Flags: needinfo?(yliao) → needinfo?(wchang)
ping UX ;)

(In reply to Yi-Fan Liao [:yifan][:yliao] from comment #3)
> Created attachment 8492878 [details]
> gallery.png
> 
> Please see the attachments.
> 
> I'm not sure if this is an issue or by design. Wayne do you know about this?
Flags: needinfo?(wchang) → needinfo?(mtsai)

Comment 5

4 years ago
Hi Yi-Fan, Please follow the gallery.png font size. That is the correct one. Thanks.
Flags: needinfo?(mtsai) → needinfo?(yliao)
Thank you Mike! Will work on a patch shortly.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(yliao)

Updated

4 years ago
status-b2g-v2.0: --- → affected
status-b2g-v2.0M: --- → affected

Updated

4 years ago
Flags: needinfo?(mtsai)
See Also: → bug 973547
Created attachment 8495134 [details]
bluetooth.png

The font size in browser.png is the same as the bluetooth modal dialog uses the same system wide font size setting. Please see bug 973547 for the original bluetooth modal dialog font size.

If we change the font size in browser.png to match the one in gallery.png, the bluetooth dialog font size will also be changed, please see bluetooth.png.

Is this OK? Or should we keep the font size in bluetooth dialog unchanged and only fix the font size in browser app?

Comment 8

4 years ago
Hi Harly, Can you please help Yi-Fan on this ?
Flags: needinfo?(mtsai) → needinfo?(hhsu)

Comment 9

4 years ago
Hi Yi-Fan,
The browser dialog should follow the same font size as the delete dialog in gallery, as they both are confirmation dialogs. For the bluetooth dialog, as it is an input dialog, which is different from confirmation dialog. I would say that we should keep it unchanged and use the smaller font size. 

Moreover, for future input dialog, we will get rid of the title and descriptions, and will just have a input field with OK and Cancel button. Just to let you know in advance.
Flags: needinfo?(hhsu)

Updated

4 years ago
Status: ASSIGNED → NEW
Assignee: nobody → selee
(Reporter)

Comment 10

4 years ago
Created attachment 8498710 [details]
history.png
(Reporter)

Comment 11

4 years ago
Created attachment 8498711 [details]
cookies.png
(Reporter)

Comment 12

4 years ago
Changed the font-size from 1.5rem to 2.2rem in confirm.css(as mentioned in comment#9) and please find the attached history & cookies screenshots.

form[role="dialog"][data-type="confirm"] p span {
    font-size: 1.5rem; ---> font-size: 2.2rem
    display: block;
    line-height: 1.7rem;
    color: rgba(255,255,255,0.6);
}
Assignee: selee → nobody
(Reporter)

Comment 13

4 years ago
Hi Yliao,

Would you please check the attached Screenshots and code change in css.
If it is fine i will upload PR for it.

Thanks..
Sireesha
Flags: needinfo?(yliao)
[Blocking Requested - why for this release]: Inconsistency of font size in modal dialogs.

Hi Sireesha, please check if the modification affect other dialogs.
Flags: needinfo?(yliao)
[Blocking Requested - why for this release]: Inconsistency of font size in modal dialogs.
blocking-b2g: --- → 2.0?

Comment 16

4 years ago
Triage group: This is visual enhancement, does not block.
blocking-b2g: 2.0? → -

Comment 17

9 months ago
Firefox OS is not being worked on
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.