1059077 - [Browser]Clear browsing and Clear cookies and stored data dialogs font is small

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[vsireesha246]

STR:

1.Open Browser
2.Settings->click on Clear browsing or Clear cookies and stored data dialogs font is small buttons
3.The Font is small compared to other dialogs like:Gallery,video,etc

Comment 1

[vsireesha246]

Hi Yliao,

The dialogs used in Bowser app is different from other apps.
We can increase the Font size for Browser app as well.
Please let me know your feedback about this issue in V2.0.

Thanks..
Sireesha

Comment 2

[yifan [:yifan][:yliao]]

Attachment: browser.png

Comment 3

[yifan [:yifan][:yliao]]

Attachment: gallery.png

Please see the attachments.

I'm not sure if this is an issue or by design. Wayne do you know about this?

Comment 4

[Wayne Chang [:wchang]]

ping UX ;)

(In reply to Yi-Fan Liao [:yifan][:yliao] from comment #3)
> Created attachment 8492878 [details]
> gallery.png
> 
> Please see the attachments.
> 
> I'm not sure if this is an issue or by design. Wayne do you know about this?

Comment 5

[GoodMike]

Hi Yi-Fan, Please follow the gallery.png font size. That is the correct one. Thanks.

Comment 6

[yifan [:yifan][:yliao]]

Thank you Mike! Will work on a patch shortly.

Comment 7

[yifan [:yifan][:yliao]]

Attachment: bluetooth.png

The font size in browser.png is the same as the bluetooth modal dialog uses the same system wide font size setting. Please see bug 973547 for the original bluetooth modal dialog font size.

If we change the font size in browser.png to match the one in gallery.png, the bluetooth dialog font size will also be changed, please see bluetooth.png.

Is this OK? Or should we keep the font size in bluetooth dialog unchanged and only fix the font size in browser app?

Comment 8

[GoodMike]

Hi Harly, Can you please help Yi-Fan on this ?

Comment 9

[Harly Hsu[:harly]]

Hi Yi-Fan,
The browser dialog should follow the same font size as the delete dialog in gallery, as they both are confirmation dialogs. For the bluetooth dialog, as it is an input dialog, which is different from confirmation dialog. I would say that we should keep it unchanged and use the smaller font size. 

Moreover, for future input dialog, we will get rid of the title and descriptions, and will just have a input field with OK and Cancel button. Just to let you know in advance.

Comment 10

[vsireesha246]

Attachment: history.png

Comment 11

[vsireesha246]

Attachment: cookies.png

Comment 12

[vsireesha246]

Changed the font-size from 1.5rem to 2.2rem in confirm.css(as mentioned in comment#9) and please find the attached history & cookies screenshots.

form[role="dialog"][data-type="confirm"] p span {
    font-size: 1.5rem; ---> font-size: 2.2rem
    display: block;
    line-height: 1.7rem;
    color: rgba(255,255,255,0.6);
}

Comment 13

[vsireesha246]

Hi Yliao,

Would you please check the attached Screenshots and code change in css.
If it is fine i will upload PR for it.

Thanks..
Sireesha

Comment 14

[yifan [:yifan][:yliao]]

[Blocking Requested - why for this release]: Inconsistency of font size in modal dialogs.

Hi Sireesha, please check if the modification affect other dialogs.

Comment 15

[yifan [:yifan][:yliao]]

[Blocking Requested - why for this release]: Inconsistency of font size in modal dialogs.

Comment 16

[howie [:howie]]

Triage group: This is visual enhancement, does not block.

Comment 17

[BMO Automation]

Firefox OS is not being worked on