Closed Bug 973547 Opened 10 years ago Closed 10 years ago

Enter device name overlay has a wrong layout.

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.4 S4 (28mar)

People

(Reporter: vicky, Assigned: paco)

References

Details

Attachments

(4 files)

bluetooth_modal current situation
58.42 KB, image/png
Details
confirm_with_keyboard.png
59.03 KB, image/png
vicky
: ui-review+
Details
confirm_without_keyboard.png
82.51 KB, image/png
Details
Patch in github
46 bytes, text/x-github-pull-request
arnau
: review+
Details | Review 
Enter or change device name overlay has a wrong layout. Overlays do not have a header with actions, close/cancel and ok/confirm actions are buttons on the bottom of the screen. We need to change this in order to preserve consistency in our patterns.
Assignee: nobody → arnau

        Attachment #8393435 -
        Flags: ui-review?(vpg)

    
    

    
  


  

    
    

    
  

      
      
      
      

        Attached file
          
        Patch in github
        — 
      

    


  

        Attachment #8393437 -
        Flags: review?(arnau)
Assignee: arnau → pacorampas

    
    

    
  
Comment on attachment 8393437 [details] [review]
Patch in github

Thanks Paco!

        Attachment #8393437 -
        Flags: review?(arnau) → review+

    
    

    
  
Merged: b527ca92d069458f2216eb859a989aea48ca5269
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S4 (28mar)

    
  

        Attachment #8393435 -
        Flags: ui-review?(vpg) → ui-review+
See Also:  → 1059077

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: