1059102 - B2G NFC: Better logging in (un)RegisterPeerTarget

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Right now when app set onpeeready callback, we didn't show which appId registers this.

Also currentPeerAppId is set when checkP2PRegisterion, however I think it should be set in notifyUserAcceptedP2P.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I'll move handling currentPeerAppId in Bug 1055960.
Also I'd do the following renaming
1. rename msg[name] to message, as these unconsistent naming rule actually causes several typo.
2. rename message.json to message.data, as from http://lxr.mozilla.org/mozilla-central/source/content/base/public/nsIMessageManager.idl#185, the json field is deprecated.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: add logging

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: rename msg[name] to message

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: rename json to data.

Comment 5

[Dimi Lee [:dimi]]

Comment on attachment 8479751 [details] [diff] [review]
Part 3: rename json to data.

Review of attachment 8479751 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8479749 [details] [diff] [review]
Part 1: add logging

Review of attachment 8479749 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/gonk/Nfc.js
@@ +484,3 @@
>     */
>    receiveMessage: function receiveMessage(message) {
> +    debug("Received '" + JSON.stringify(message) + "' message from gMessageManager");

this line should be removed since we already printed this in line 240.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: add logging. v2

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5ce43c763281
https://hg.mozilla.org/integration/b2g-inbound/rev/e1b969fa5921
https://hg.mozilla.org/integration/b2g-inbound/rev/8365f90a9cec

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5ce43c763281
https://hg.mozilla.org/mozilla-central/rev/e1b969fa5921
https://hg.mozilla.org/mozilla-central/rev/8365f90a9cec