Closed
Bug 1059107
Opened 11 years ago
Closed 11 years ago
[RTL] Back button's icon in Keyboard settings is reversed
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(ux-b2g:2.2)
RESOLVED
DUPLICATE
of bug 1073489
| ux-b2g | 2.2 |
People
(Reporter: nefzaoui, Unassigned)
References
Details
(Whiteboard: [2.1-Arabic-RTL-bug-bash])
Attachments
(1 file)
|
22.05 KB,
image/png
|
Details |
No description provided.
Updated•11 years ago
|
Component: Gaia::PerformanceTest → Gaia
Comment 1•11 years ago
|
||
Hi iam new to this bugzilla and am interested to solve this bug can you give further information... regarding this
| Reporter | ||
Comment 2•11 years ago
|
||
(In reply to sanjaygouri77 from comment #1)
> Hi iam new to this bugzilla and am interested to solve this bug can you give
> further information... regarding this
When in RTL locale (e.g Arabic), going to Keyboard settings from Settings -> Keyboards -> Built In Keyboard, you can clearly see that the back button is on the top right (which is the right thing, as it should be on the top left when in LTR locale(like English)). However the arrow which should be pointing to the right, is actually pointing to the left, that's wrong and it shouldn't be like this
I think think this bug should be handled by UX team though since it involves icon font which is slowly replacing using PNG assets..
I traced the bug to the icon font used in gaia-header component and other components, and apparently, it lacks a RTL arrow..
Stephany, could you please assign who's working on the icons font to fix it if they don't have any other priorities? :)
Thanks
Flags: needinfo?(swilkes)
Comment 3•11 years ago
|
||
Ahmed, I still see the button displaying correctly in other apps. Is it perhaps a matter of Settings app just not using the correct icon? Let me know if you can tell. Thanks!
| Reporter | ||
Comment 4•11 years ago
|
||
Bug 1015297 has just landed yesterday, which changed Settings app too to use gaia-header, same bug.
Also there should be a reference for a RTL back button near https://github.com/mozilla-b2g/gaia/blob/master/shared/elements/gaia-header/style.css#L254
Occurs in 1015292 and 1015247 but not in 1011604, however the common thing is that there's no reference to a RTL back button which is exactly why it's not showing up, which also might mean it doesn't exist in the icon font.. :)
Comment 5•11 years ago
|
||
Ahmed, can you please attach screenshots so we can get some design work slated for this for 2.2? Thanks!
Flags: needinfo?(swilkes)
| Reporter | ||
Comment 6•11 years ago
|
||
I know the bug says keyboard settings but had to take this as quick as I could since my device was turning off in a sec (dying battery).
Also, as I said I found this happening anywhere gaia-header component is used.
The build that the screenshot was took from is from 31/08.
Thanks :)
Updated•11 years ago
|
ux-b2g: --- → 2.2
Updated•11 years ago
|
Component: Gaia → Gaia::Settings
| Reporter | ||
Comment 7•11 years ago
|
||
Let's have 1073489 to track this for its more accurate title :)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Comment 8•10 years ago
|
||
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15732/
Flags: in-moztrap+
You need to log in
before you can comment on or make changes to this bug.
Description
•