1059141 - Proxy exceptions broken for GUI applications due to missing leading '*' for domain matches

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

I dislike this endless story about proxies... So at the moment at least on OS X our proxy config is broken for GUI applications. Looks like the changes as went in with bug 997721 were not enough, and the '*' in-front of the domain excludes is really necessary. Not sure when I tested this on OS X when I implemented it for Ubuntu. :/

https://hg.mozilla.org/qa/puppet/file/4bbb537b1d28/manifests/qa-config.pp#l43

.scl3.mozilla.com => *.scl3.mozilla.com

I'm not sure if the no_proxy environment variable on Ubuntu and OS X will support that, so maybe we have to add this in the code of gui.pp. And maybe we should better do the same for Ubuntu too.

Karl, do you have an advice here?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Karl replied to me on IRC. So one solution would be to add duplicated entries just with a leading asterix to the exceptions list. But it's not clear if this can cause side-effects. So better here is really to keep the exception list without asterix, and add them for Ubuntu and OS X GUI proxy settings.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Attachment: gui_proxy v1

Simple substitution to add a '*' in-front of a domain entry with a leading dot.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

https://hg.mozilla.org/qa/puppet/rev/4a9202786ff0

Crossing fingers that this was the last patch for proxies. Now we should have it.