Closed Bug 1059224 Opened 10 years ago Closed 10 years ago

[v2.1] Update browser launch method to use manifest url instead of app name

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: RobertC, Assigned: RobertC)

References

Details

Attachments

(1 file)

The browser launch method needs to be updated so that it uses the manifest url to open. This should be done because at this time there are 2 "Browser" apps and the method opens the old app.
This patch will break all of the tests that use the Browser app since the page object is no longer accurate. Also started an adhoc run to see if the PR breaks other tests. http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame.mozilla-central.ui.adhoc/109/
Attachment #8479841 - Flags: review?(zcampbell)
Attachment #8479841 - Flags: review?(viorela.ioia)
Attachment #8479841 - Flags: review?(florin.strugariu)
Comment on attachment 8479841 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369 As this affects some other projects Dave can you also take a look please
Attachment #8479841 - Flags: review?(dave.hunt)
Attachment #8479841 - Flags: review?(dave.hunt) → review-
Attachment #8479841 - Flags: review?(zcampbell)
Attachment #8479841 - Flags: review?(viorela.ioia)
Attachment #8479841 - Flags: review?(florin.strugariu)
Attachment #8479841 - Flags: review-
The PR is no longer needed because launching the app "Browser" by name opens the correct app now.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Since the browser that opens is inconsistent we need to open app via manifest URL.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Attachment #8479841 - Flags: review?(zcampbell)
Attachment #8479841 - Flags: review?(dave.hunt)
Attachment #8479841 - Flags: review-
Comment on attachment 8479841 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369 r-, TBPL is failing. The browser app object's manifest_url property needs to point to the old app
Attachment #8479841 - Flags: review?(zcampbell)
Attachment #8479841 - Flags: review?(dave.hunt)
Attachment #8479841 - Flags: review-
Comment on attachment 8479841 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369 I updated the PR.
Attachment #8479841 - Flags: review?(zcampbell)
Attachment #8479841 - Flags: review?(dave.hunt)
Attachment #8479841 - Flags: review-
Comment on attachment 8479841 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369 Please add unit tests for launching via the manifest URL for apps with and without entry points.
Attachment #8479841 - Flags: review?(dave.hunt) → review-
Attachment #8479841 - Flags: review- → review?(dave.hunt)
Blocks: 1059245
Attachment #8479841 - Flags: review?(florin.strugariu)
Attachment #8479841 - Flags: review?(dave.hunt) → review-
Attachment #8479841 - Flags: review- → review?(dave.hunt)
Comment on attachment 8479841 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369 Could nit on some more stuff but I'd really like to move on, to unblock fixing the browser app object so I'm giving this r+.
Attachment #8479841 - Flags: review?(zcampbell) → review+
Comment on attachment 8479841 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369 I'm happy if Zac's happy.
Attachment #8479841 - Flags: review?(dave.hunt)
Attachment #8479841 - Flags: review?(florin.strugariu)
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: