Closed
Bug 1059224
Opened 10 years ago
Closed 10 years ago
[v2.1] Update browser launch method to use manifest url instead of app name
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: RobertC, Assigned: RobertC)
References
Details
Attachments
(1 file)
The browser launch method needs to be updated so that it uses the manifest url to open.
This should be done because at this time there are 2 "Browser" apps and the method opens the old app.
Assignee | ||
Comment 1•10 years ago
|
||
This patch will break all of the tests that use the Browser app since the page object is no longer accurate.
Also started an adhoc run to see if the PR breaks other tests.
http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame.mozilla-central.ui.adhoc/109/
Attachment #8479841 -
Flags: review?(zcampbell)
Attachment #8479841 -
Flags: review?(viorela.ioia)
Attachment #8479841 -
Flags: review?(florin.strugariu)
Comment 2•10 years ago
|
||
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369
As this affects some other projects Dave can you also take a look please
Attachment #8479841 -
Flags: review?(dave.hunt)
Updated•10 years ago
|
Attachment #8479841 -
Flags: review?(dave.hunt) → review-
Comment 3•10 years ago
|
||
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369
r-
Attachment #8479841 -
Flags: review?(zcampbell)
Attachment #8479841 -
Flags: review?(viorela.ioia)
Attachment #8479841 -
Flags: review?(florin.strugariu)
Attachment #8479841 -
Flags: review-
Assignee | ||
Comment 4•10 years ago
|
||
The PR is no longer needed because launching the app "Browser" by name opens the correct app now.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Assignee | ||
Comment 5•10 years ago
|
||
Since the browser that opens is inconsistent we need to open app via manifest URL.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Assignee | ||
Updated•10 years ago
|
Attachment #8479841 -
Flags: review?(zcampbell)
Attachment #8479841 -
Flags: review?(dave.hunt)
Attachment #8479841 -
Flags: review-
Comment 6•10 years ago
|
||
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369
r-, TBPL is failing.
The browser app object's manifest_url property needs to point to the old app
Attachment #8479841 -
Flags: review?(zcampbell)
Attachment #8479841 -
Flags: review?(dave.hunt)
Attachment #8479841 -
Flags: review-
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369
I updated the PR.
Attachment #8479841 -
Flags: review?(zcampbell)
Attachment #8479841 -
Flags: review?(dave.hunt)
Attachment #8479841 -
Flags: review-
Comment 8•10 years ago
|
||
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369
Please add unit tests for launching via the manifest URL for apps with and without entry points.
Attachment #8479841 -
Flags: review?(dave.hunt) → review-
Assignee | ||
Updated•10 years ago
|
Attachment #8479841 -
Flags: review- → review?(dave.hunt)
Assignee | ||
Updated•10 years ago
|
Attachment #8479841 -
Flags: review?(florin.strugariu)
Updated•10 years ago
|
Attachment #8479841 -
Flags: review?(dave.hunt) → review-
Assignee | ||
Updated•10 years ago
|
Attachment #8479841 -
Flags: review- → review?(dave.hunt)
Comment 9•10 years ago
|
||
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369
Could nit on some more stuff but I'd really like to move on, to unblock fixing the browser app object so I'm giving this r+.
Attachment #8479841 -
Flags: review?(zcampbell) → review+
Comment 10•10 years ago
|
||
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369
I'm happy if Zac's happy.
Attachment #8479841 -
Flags: review?(dave.hunt)
Updated•10 years ago
|
Attachment #8479841 -
Flags: review?(florin.strugariu)
Comment 11•10 years ago
|
||
Thanks everyone :)
https://github.com/mozilla-b2g/gaia/commit/2edf0bffd5f4ebc53f0abf015e17bb46438ad1e0
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•