[v2.1] Update browser launch method to use manifest url instead of app name

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: RobertC, Assigned: RobertC)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The browser launch method needs to be updated so that it uses the manifest url to open. 
This should be done because at this time there are 2 "Browser" apps and the method opens the old app.
(Assignee)

Comment 1

4 years ago
Created attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369

This patch will break all of the tests that use the Browser app since the page object is no longer accurate.

Also started an adhoc run to see if the PR breaks other tests.
http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame.mozilla-central.ui.adhoc/109/
Attachment #8479841 - Flags: review?(zcampbell)
Attachment #8479841 - Flags: review?(viorela.ioia)
Attachment #8479841 - Flags: review?(florin.strugariu)
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369

As this affects some other projects Dave can you also take a look please
Attachment #8479841 - Flags: review?(dave.hunt)
Attachment #8479841 - Flags: review?(dave.hunt) → review-

Comment 3

4 years ago
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369

r-
Attachment #8479841 - Flags: review?(zcampbell)
Attachment #8479841 - Flags: review?(viorela.ioia)
Attachment #8479841 - Flags: review?(florin.strugariu)
Attachment #8479841 - Flags: review-
(Assignee)

Comment 4

4 years ago
The PR is no longer needed because launching the app "Browser" by name opens the correct app now.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
(Assignee)

Comment 5

4 years ago
Since the browser that opens is inconsistent we need to open app via manifest URL.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
(Assignee)

Updated

4 years ago
Attachment #8479841 - Flags: review?(zcampbell)
Attachment #8479841 - Flags: review?(dave.hunt)
Attachment #8479841 - Flags: review-

Comment 6

4 years ago
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369

r-, TBPL is failing.

The browser app object's manifest_url property needs to point to the old app
Attachment #8479841 - Flags: review?(zcampbell)
Attachment #8479841 - Flags: review?(dave.hunt)
Attachment #8479841 - Flags: review-
(Assignee)

Comment 7

4 years ago
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369

I updated the PR.
Attachment #8479841 - Flags: review?(zcampbell)
Attachment #8479841 - Flags: review?(dave.hunt)
Attachment #8479841 - Flags: review-
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369

Please add unit tests for launching via the manifest URL for apps with and without entry points.
Attachment #8479841 - Flags: review?(dave.hunt) → review-
(Assignee)

Updated

4 years ago
Attachment #8479841 - Flags: review- → review?(dave.hunt)

Updated

4 years ago
Blocks: 1059245
(Assignee)

Updated

4 years ago
Attachment #8479841 - Flags: review?(florin.strugariu)
Attachment #8479841 - Flags: review?(dave.hunt) → review-
(Assignee)

Updated

4 years ago
Attachment #8479841 - Flags: review- → review?(dave.hunt)

Comment 9

4 years ago
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369

Could nit on some more stuff but I'd really like to move on, to unblock fixing the browser app object so I'm giving this r+.
Attachment #8479841 - Flags: review?(zcampbell) → review+
Comment on attachment 8479841 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23369

I'm happy if Zac's happy.
Attachment #8479841 - Flags: review?(dave.hunt)

Updated

4 years ago
Attachment #8479841 - Flags: review?(florin.strugariu)

Comment 11

4 years ago
Thanks everyone :)

https://github.com/mozilla-b2g/gaia/commit/2edf0bffd5f4ebc53f0abf015e17bb46438ad1e0
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.