1059248 - [mozrunner] Accept a test name when checking for crashes in DeviceRunner

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Currently mozrunner's DeviceRunner tries to determine the last test name by looking at the process output, however this is not working at least for physical devices. We should allow the test harness to specify the test name when we check for crashes.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Accept a test name when checking for crashes. v1.0

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=dba414c91f59

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8479851 [details] [diff] [review]
Accept a test name when checking for crashes. v1.0

Review of attachment 8479851 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks this looks good, but r- for now because this will break desktop marionette.

::: testing/marionette/client/marionette/marionette.py
@@ +729,5 @@
>                  returncode = self.emulator.proc.returncode
>                  name = 'emulator'
>                  crashed = True
>          elif self.instance:
> +            if self.instance.check_for_crashes(test_name=self.test_name):

I don't think 'instance.check_for_crashes' has a test_name either:
http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/geckoinstance.py#96

There's a lot of unnecessary abstraction going on here. Maybe we can just change this to instance.runner.check_for_crashes and then delete instance.check_for_crashes (I don't know if it is used anywhere else though).

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Accept a test name when checking for crashes. v1.1

I've removed the check_for_crashes from geckoinstance.py as suggested. Running a more expansive try to see if anything breaks, but I couldn't find anywhere else this was being called.

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f4cf21d66956

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8479979 [details] [diff] [review]
Accept a test name when checking for crashes. v1.1

Review of attachment 8479979 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm, thanks!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97d41094b879

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/97d41094b879