Closed
Bug 1059279
Opened 9 years ago
Closed 9 years ago
Icon used for the "additional links" menu (eg mcMerge, cancel all builds) isn't clear
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: jfrench)
References
()
Details
Attachments
(1 file)
I've been asked about this one several times on IRC - people can't find the "cancel all builds" button. I think we should make the current button more obviously a "more options" type menu - ie just a triangle (or the three dots thing from mobile UIs) rather than the current mixture of triange/up-arrow/square thing.
Reporter | ||
Comment 1•9 years ago
|
||
http://glyphicons.com/ -> icon "more" looks like a possible candidate?
Reporter | ||
Updated•9 years ago
|
No longer blocks: treeherder-sheriff-transition
Reporter | ||
Updated•9 years ago
|
Blocks: treeherder-dev-transition
Comment 2•9 years ago
|
||
I'm not really sure if the more icon is any more obvious. Another alternative would be to just break out "Cancel all builds" into its own button, since it's really the only one that most people would want to use.
Assignee | ||
Comment 3•9 years ago
|
||
I did some of this already including the "cancel all" button breakout per comment#2 using glyphicon-minus-sign, which is a nice variant stop-button. And keeping just the down chevron with no icon for the existing menu. It looks pretty nice. Assigning myself.
Assignee | ||
Comment 4•9 years ago
|
||
Please see the above PR for review and status.
Reporter | ||
Updated•9 years ago
|
Attachment #8496450 -
Flags: review?(cdawson)
Reporter | ||
Comment 5•9 years ago
|
||
Like the change, thank you :-)
Comment 6•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/05a4293e129fdab821f76f6efb585a27afc96aa5 Bug 1059279 - Improve resultset menu bar clarity and cancel access https://github.com/mozilla/treeherder-ui/commit/00ab4f4da74046fdda094da879629d20ea52d044 Merge pull request #209 from tojonmz/resultset-bar-improvements Bug 1059279 - Improve resultset menu bar clarity and cancel access
Updated•9 years ago
|
Attachment #8496450 -
Flags: review?(cdawson) → review+
Reporter | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•9 years ago
|
||
Verified fixed and working correctly on dev/stage.
Comment 8•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/c55a230ffea6314bcd2b4d4c0af116c4c07af589 Bug 1059279 - Improve resultset menu bar clarity and cancel access https://github.com/mozilla/treeherder/commit/ebc0982f15400c6387c5b8edef286f0045e0bdea Merge pull request #209 from tojonmz/resultset-bar-improvements Bug 1059279 - Improve resultset menu bar clarity and cancel access
You need to log in
before you can comment on or make changes to this bug.
Description
•