Closed Bug 1077679 Opened 5 years ago Closed 5 years ago

Update the resultset icon colors post-bootstrap 3.2 update

Categories

(Tree Management :: Treeherder, defect, P5, minor)

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

References

()

Details

Attachments

(1 file)

Last week I made this change to improve the resultset usability
https://github.com/mozilla/treeherder-ui/pull/209

In doing so, I updated bootstrap directly on a misunderstanding on my part with wlach in channel. As I suspected might happen, we recently updated bootstrap to 3.2 and in doing so stepped on that custom color change.

This bug represents the minor work to implement it the desired way, insulated from future bootstrap updates.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Attached file treeherder-ui-PR#215
Please see the above PR for review and status.
Attachment #8499865 - Flags: review?(cdawson)
Blocks: 1059279
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/64ef86841563e819d2bcc8aefdcca57a802114ca
Bug 1077679 -  Update the resultset icon colors post-bootstrap 3.2

https://github.com/mozilla/treeherder-ui/commit/909334b191321a093101aa56e4933f7d904a6a08
Merge pull request #215 from tojonmz/update-resultset-bar

Bug 1077679 -  Update the resultset icon colors post-bootstrap 3.2
Verified fixed and working correctly once again, on dev/stage.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Attachment #8499865 - Flags: review?(cdawson) → review+
Status: RESOLVED → VERIFIED
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/969ed3df6ad8a5ee7f994905e1917249057060ea
Bug 1077679 -  Update the resultset icon colors post-bootstrap 3.2

https://github.com/mozilla/treeherder/commit/bac8e3fe9562997b352fe1a4248aea633caa560e
Merge pull request #215 from tojonmz/update-resultset-bar

Bug 1077679 -  Update the resultset icon colors post-bootstrap 3.2
You need to log in before you can comment on or make changes to this bug.