1059292 - nickserv messages sometimes displayed

Status: NEW

(Chat Core :: IRC, defect)

Description

[Florian Quèze [:florian]]

I saw nickserv messages twice today on my freenode account (which suffers from bug 955220).

NickServ: This nickname is registered. Please choose a different nickname, or identify via /msg NickServ identify <password>.
NickServ: You are now identified for fqueze_.

I looked in the debug log for the time between these 2 messages, it was 18s.

See also bug 955209 where we bumped the timer from 1s to 10s.

Related IRC conversation from #instantbird:

14:46:59 - flo-retina: we receive "SASL authentication failed" and then "SASL authentication aborted"
14:47:13 - flo-retina: after that we send "IDENTIFY <password not logged>"
14:47:33 - flo-retina: and then we join #gsoc _twice_ (we have a bug on file for that, right?) [we didn't, filed bug 1059289]
14:48:23 - flo-retina: then we receive plenty of stuff (likely the MOTD)
14:49:18 - flo-retina: after receiving the MOTD we get ":NickServ!NickServ@services. NOTICE fqueze :This nickname is registered. Please "[blah]
14:49:45 - flo-retina: then we get ":cameron.freenode.net 421 fqueze IDENTIFY :Unknown command"
14:50:02 - flo-retina: then we send "NICKSERV IDENTIFY <password not logged>"
14:50:43 - flo-retina: then we actually enter #gsoc and receive the list of participants
14:51:45 - flo-retina: only after all of that is done we get "NickServ!NickServ@services. NOTICE fqueze :You are now identified"
14:52:10 - clokep_work: I don't think we actually do have a bug about trying to join things twice.
14:53:03 - clokep_work: What's the time difference between "This nickname is not registered..." and "You are now identified"?
14:53:30 - flo-retina: "This nickname is registered." is at 14:27:48
14:53:48 - flo-retina: "You are now identified" is at 14:28:06
14:53:55 - flo-retina: so 18s
14:59:26 - clokep_work: Hmm...I think we display it after 10 seconds.
14:59:29 - flo-retina: would it help if we waited until the end of the MOTD to send the JOIN commands?
15:00:16 - flo-retina: also, would be nice if possible (I really don't know if it is) if we could wait for the end of the identification (either success, or unrecoverable failure) before attempting to join channels.
15:01:04 - flo-retina: indeed, 10s: http://mxr.mozilla.org/comm-central/source/chat/protocols/irc/ircServices.jsm#224
15:01:15 - flo-retina: so my initial assumption that the message showing was just caused by the delay was correct :)
15:02:18 - clokep_work: flo-retina: It probably would, but there's no guarantee a server sends a MOTD.