1059385 - Update the old Tarako review process

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P2)

Description

[Mark Striemer [:mstriemer]]

The old Tarako review process added a checkbox to the regular review page. Since developers will now opt in to the process this has to change.

Options:

1. Change it to radio buttons (passed, failed, not reviewed).
    a) Only show it when the app has a review requested.
    b) Only show it if the reviewer has the "Tarako Reviewers" group.
    c) Update the server to set the review status based on the radio button.
2. Remove the checkbox and associated server-side code.
    a) All Tarako reviews will be done through the Tarako review queue.

Comment 1

[Mark Striemer [:mstriemer]]

@eviljeff Which option would you prefer?

Comment 2

[Andrew Williamson [:eviljeff]]

I'd say 2), assuming we can still remove/add the tarako tag via the app's manage page and achieve the same effect.

BUT we are still in a phase of retesting the back catalogue (i.e. there is no opt in) and are planning another pass to cover apps submitted since the retesting started.  For this to be an efficient process the functionality needs to stay in the reviewer tools.  So can this wait until that second pass finishes?

Comment 3

[Mark Striemer [:mstriemer]]

I'll leave it in for now.

Comment 4

[Mark Striemer [:mstriemer]]

@eviljeff the word on the street is that retesting the back catalogue is done. Can this be removed now?

Comment 5

[Andrew Williamson [:eviljeff]]

(In reply to Mark Striemer [:mstriemer] from comment #4)
> @eviljeff the word on the street is that retesting the back catalogue is
> done. Can this be removed now?

the 1st pass is done.  We're planning a 2nd pass to catch apps that weren't live in May when I initially pulled the list.

Comment 6

[Andrew Williamson [:eviljeff]]

This can be removed now.  The 2nd pass didn't happen.

Comment 7

[Andrew Williamson [:eviljeff]]

https://github.com/mozilla/zamboni/pull/3229

Comment 8

[Andrew Williamson [:eviljeff]]

QA - its just that the checkbox isn't there on the reviewer review page anymore.

Comment 9

[Valentina Virlics [:vvalentina], VPN QA]

Verified as fixed on MP-stage and MP-dev on FF43(Win 7).
Postfix screenshot: http://screencast.com/t/ISHzoIvN
Closing bug.