Closed
Bug 1059476
Opened 10 years ago
Closed 10 years ago
update certificate exception handling in seamonkey to deal with bug 940506
Categories
(SeaMonkey :: Security, defect)
SeaMonkey
Security
Tracking
(seamonkey2.29 unaffected, seamonkey2.30 fixed, seamonkey2.31 fixed)
RESOLVED
FIXED
seamonkey2.31
Tracking | Status | |
---|---|---|
seamonkey2.29 | --- | unaffected |
seamonkey2.30 | --- | fixed |
seamonkey2.31 | --- | fixed |
People
(Reporter: mkmelin, Assigned: neil)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.33 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1046328 +++ Bug 940506 removed the nsIRecentBadCerts interface and implementation, which means that the old way of adding certificate exceptions do not work. I thought there was a bug on this already, but I guess not. What needs to happen is everywhere Thunderbird opens the certificate exception override dialog, it needs to pass along the nsISSLStatus from the connection that failed. See for reference the patch in bug 1025332. -- For thunderbird, see bug 1046328 At least this place should be changed to pass the status. http://mxr.mozilla.org/comm-central/source/suite/mailnews/mailTasksOverlay.js#217
Assignee | ||
Comment 1•10 years ago
|
||
(In reply to Magnus Melin) > At least this place should be changed to pass the status. > http://mxr.mozilla.org/comm-central/source/suite/mailnews/mailTasksOverlay.js#217 We fixed one caller in bug 1034203 but this one got overlooked; thanks for filing this bug.
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
status-seamonkey2.29:
--- → unaffected
status-seamonkey2.30:
--- → affected
status-seamonkey2.31:
--- → affected
Comment on attachment 8480265 [details] [diff] [review] Untested patch r/a=me by visual code inspection
Attachment #8480265 -
Flags: review?(iann_bugzilla) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Pushed comm-central changeset 9eff7298d806.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.31
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8480265 [details] [diff] [review] Untested patch I got my approvals mixed up and accidentally checked this in without approval. Sorry about that. [Approval Request Comment] Regression caused by (bug #): 940506 User impact if declined: Can't add exceptions for mail servers Testing completed (on m-c, etc.): Landed on c-c Risk to taking this patch (and alternatives if risky): Low String changes made by this patch: None
Attachment #8480265 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 6•10 years ago
|
||
http://hg.mozilla.org/releases/comm-aurora/rev/8768b2c38db0
Attachment #8480265 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 7•10 years ago
|
||
Followup to fix typo f=Ratty rs=Callek a=Callek for checkin to a CLOSED TREE http://hg.mozilla.org/releases/comm-beta/rev/673ba79dc3f4 comm-beta == SeaMonkey 2.30b2
You need to log in
before you can comment on or make changes to this bug.
Description
•