1034203 - In about:certerror send the failed channel from the docshell to the Security Exceptions Dialog.

Status: RESOLVED FIXED

(SeaMonkey :: Security, defect)

Description

[Philip Chee]

(From Bug 1025332 comment #0)
> Bug 1025330 aims to make available the failed channel that led to a
> particular SSL error page. In the certificate exception dialog, we can make
> use of this rather than the flawed recent bad cert service.

We should update our certerror exception dialog handling to match Firefox.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix

q.v. Core::PSM Bug 1025332 (certificate exception dialog: use the exposed failed channel from the docshell instead of the recent bad cert service)
https://hg.mozilla.org/mozilla-central/rev/2d734c2008b1

Tested on:
https://tv.eurosport.com/
https://testssl-expire.disig.sk/index.en.html

Comment 2

[[e-mail]]

Comment on attachment 8450430 [details] [diff] [review]
Patch v1.0 Proposed fix

>+      let docshell = ownerDoc.defaultView
>+                             .QueryInterface(Ci.nsIInterfaceRequestor)
>+                             .getInterface(Ci.nsIWebNavigation)
>+                             .QueryInterface(Ci.nsIDocShell)
Missing semicolon

>-      var params = { exceptionAdded : false };
>+      let params = { exceptionAdded : false, sslStatus : sslStatus };
Grrr...

Comment 3

[Philip Chee]

Dependant bugs have landed on mozilla-central.
Pushed comm-central changeset b85bb712678a
https://hg.mozilla.org/comm-central/rev/b85bb712678a

Comment 4

[[e-mail]]

This only fixed one of our callers. Bug 1059476 is filed on our other caller.