Closed Bug 1034203 Opened 10 years ago Closed 10 years ago

In about:certerror send the failed channel from the docshell to the Security Exceptions Dialog.

Categories

(SeaMonkey :: Security, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.30

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

(From Bug 1025332 comment #0)
> Bug 1025330 aims to make available the failed channel that led to a
> particular SSL error page. In the certificate exception dialog, we can make
> use of this rather than the flawed recent bad cert service.

We should update our certerror exception dialog handling to match Firefox.
Depends on: 1025332
q.v. Core::PSM Bug 1025332 (certificate exception dialog: use the exposed failed channel from the docshell instead of the recent bad cert service)
https://hg.mozilla.org/mozilla-central/rev/2d734c2008b1

Tested on:
https://tv.eurosport.com/
https://testssl-expire.disig.sk/index.en.html
Attachment #8450430 - Flags: review?(neil)
Comment on attachment 8450430 [details] [diff] [review]
Patch v1.0 Proposed fix

>+      let docshell = ownerDoc.defaultView
>+                             .QueryInterface(Ci.nsIInterfaceRequestor)
>+                             .getInterface(Ci.nsIWebNavigation)
>+                             .QueryInterface(Ci.nsIDocShell)
Missing semicolon

>-      var params = { exceptionAdded : false };
>+      let params = { exceptionAdded : false, sslStatus : sslStatus };
Grrr...
Attachment #8450430 - Flags: review?(neil) → review+
Depends on: 1034270
Dependant bugs have landed on mozilla-central.
Pushed comm-central changeset b85bb712678a
https://hg.mozilla.org/comm-central/rev/b85bb712678a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.30
This only fixed one of our callers. Bug 1059476 is filed on our other caller.
You need to log in before you can comment on or make changes to this bug.