Closed
Bug 1059668
Opened 10 years ago
Closed 10 years ago
Move some keyboard removal logics from keyboard_manager.js to input_frame_manager.js
Categories
(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S4 (12sep)
People
(Reporter: mnjul, Assigned: mnjul)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
This is a very trivial issue: the frame-destroying & reference deletion codes [1] in |KeyboardManager.removeKeyboard| can actually be moved to |InputFrameManager|; and IFM probably doesn't need to expose the functions after such code moving. [1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/keyboard_manager.js#L434-L439
|
Assignee | |
Comment 1•10 years ago
|
||
I'll take this. Very low risk and can be done very fast.
Assignee: nobody → jlu
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S3 (29aug)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Tim, please help review this small patch. Thanks!
Attachment #8480433 -
Flags: review?(timdream)
|
||
Updated•10 years ago
|
Attachment #8480433 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/1baec5ecdbf913eace33981e0f79dbc3b09b1bf1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: 2.1 S3 (29aug) → 2.1 S4 (12sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•