Closed Bug 1059686 Opened 7 years ago Closed 6 years ago

Add more tests for get_error_search_term()

Categories

(Tree Management :: Treeherder, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

In bug 1057377, the search term blacklist wasn't working.
It's since been fixed, but we should add a test.
The test should also check that the bugs object returned is not just None, but:
{'open_recent': [], 'all_others': []}

...to avoid bug 1059306 happening again (since the UI expects the open_recent and all_others keys to be present).
Depends on: 1059306, 1057377
Blocks: 1072681
As part of doing bug 1057359, it's become apparent we have insufficient test coverage of the search term extraction code in, get_error_search_term().

(In reply to Ed Morley [:edmorley] from comment #0)
> The test should also check that the bugs object returned is not just None,

This is not directly related, and is pretty much covered by bug 1043338, so not doing that here.
Assignee: nobody → emorley
Blocks: 1057359
Status: NEW → ASSIGNED
No longer depends on: 1059306
Priority: P4 → P2
Summary: Add a test for the bug suggestion search term blacklist → Add more tests for get_error_search_term()
Done as part of looking at bug 1057359. Passes on Travis.
For easier to follow diffs, see the individual commits rather than the overall PR diff.
Attachment #8513879 - Flags: review?(mdoglio)
Attachment #8513879 - Flags: review?(mdoglio) → review+
Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/233764c02b2f0c4e9a9c6b1984857843e9d9618c
Bug 1059686 - Remove excess newlines in test_utils.py

https://github.com/mozilla/treeherder-service/commit/e1308fec8b9331b51d08d2e17b9c9f49c41507fa
Bug 1059686 - Correct the name of the leak error search term test

The current test is checking the extraction of the search term for the
leak case, not the standard test error case.

https://github.com/mozilla/treeherder-service/commit/817263d30b5d6f2ee31d244b2b142fad7587816e
Bug 1059686 - Add search term tests for pipe-delimited log error lines

https://github.com/mozilla/treeherder-service/commit/bfd26e60beaceff15adc619baa119f70d5e7f6d7
Bug 1059686 - Add tests for the search term blacklist

https://github.com/mozilla/treeherder-service/commit/0d32390b974a64008dfed618dab6ae574cd2f985
Bug 1059686 - Add tests for the search term full error line fall-back

Test that the full error line is used as a fall-back search term if no
test name was found, or the name found was in the blacklist.

https://github.com/mozilla/treeherder-service/commit/e33a76081aeb8f99e1fc78c17de23567a3c2f10c
Bug 1059686 - Add test for truncating test name style search terms
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.